Differential D30151

Fix mbuf leaks in various pru_send implementations
ClosedPublic
Actions

Authored by markj on May 6 2021, 9:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 19, 12:51 PM

	Unknown Object (File)
	Thu, Mar 19, 8:04 AM

	Unknown Object (File)
	Sun, Mar 15, 4:24 AM

	Unknown Object (File)
	Sat, Mar 7, 8:49 PM

	Unknown Object (File)
	Fri, Mar 6, 11:51 PM

	Unknown Object (File)
	Tue, Mar 3, 2:38 PM

	Unknown Object (File)
	Tue, Mar 3, 9:05 AM

	Unknown Object (File)
	Mon, Mar 2, 1:41 PM

Subscribers

Details

Reviewers

melifaro
tuexen
jtl

Group Reviewers

transport
network

Commits

rGd8acd2681bcf: Fix mbuf leaks in various pru_send implementations

Summary

The various protocol implementations are not very consistent about
freeing mbufs in error paths. In general, all protocols must free both
"m" and "control" upon an error, except if PRUS_NOTREADY is specified
(this is only implemented by TCP and unix(4) and requires further work
not handled in this diff), in which case "control" still must be freed.

This diff plugs various leaks in the pru_send implementations.

N.B. in general we seem to avoid calling m_freem(NULL), though this
works fine in practice and would be consistent with other kernel memory
allocators. Is there some reason to keep this pattern?

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/netinet6/raw_ip6.c:893	SPELL1	Possible Spelling Mistake
Warning	sys/netinet6/raw_ip6.c:895	SPELL1	Possible Spelling Mistake
Warning	sys/netinet6/raw_ip6.c:897	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 39059
Build 35948: arc lint + arc unit

Event Timeline

markj created this revision.May 6 2021, 9:16 PM

Herald added a reviewer: transport. · View Herald TranscriptMay 6 2021, 9:16 PM

Herald added subscribers: melifaro, bz, ae, imp. · View Herald Transcript

markj requested review of this revision.May 6 2021, 9:16 PM

markj added reviewers: melifaro, tuexen, jtl, network.May 6 2021, 9:17 PM

Harbormaster completed remote builds in B39059: Diff 88752.May 6 2021, 9:17 PM

tuexen accepted this revision.May 6 2021, 10:19 PM

This revision is now accepted and ready to land.May 6 2021, 10:19 PM

This revision was landed with ongoing or failed builds.May 12 2021, 5:10 PM

Closed by commit rGd8acd2681bcf: Fix mbuf leaks in various pru_send implementations (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGd8acd2681bcf: Fix mbuf leaks in various pru_send implementations.

Revision Contents
Changeset List

Path

Size

sys/

kern/

3 lines

netinet/

1 line

17 lines

80 lines

1 line

netinet6/

39 lines

10 lines

3 lines

Diff 88752

sys/kern/uipc_socket.c

Loading...

sys/netinet/ip_divert.c

Loading...

sys/netinet/raw_ip.c

Loading...

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/udp_usrreq.c

Loading...

sys/netinet6/raw_ip6.c

Loading...

sys/netinet6/sctp6_usrreq.c

Loading...

sys/netinet6/send.c

Loading...