stand/efi: add modulep to kernel metadata
ClosedPublic
Actions

Authored by royger on Feb 5 2021, 12:58 PM.

Details

Reviewers

tsoome
imp
manu

Commits

rG8f6f1e27fd18: stand/efi: add modulep to kernel metadata
rG7d3259775cb6: stand/efi: add modulep to kernel metadata

Summary

This mirrors the functionality of the BIOS amd64 bi_load function,
that stashes the absolute address of the module metadata. This is
required for booting as a Xen dom0 that does relocate the modulep and
the loaded modules, and thus requires adjusting the offset.

No functional change introduced, further patches will make use of this
functionality for Xen dom0 loading.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger created this revision.Feb 5 2021, 12:58 PM

Herald added subscribers: bcran, imp. · View Herald TranscriptFeb 5 2021, 12:58 PM

royger requested review of this revision.Feb 5 2021, 12:58 PM

Harbormaster completed remote builds in B36727: Diff 83403.Feb 5 2021, 12:58 PM

imp accepted this revision.Feb 5 2021, 7:48 PM

This revision is now accepted and ready to land.Feb 5 2021, 7:48 PM

Closed by commit rG7d3259775cb6: stand/efi: add modulep to kernel metadata (authored by royger). · Explain WhyFeb 16 2021, 2:28 PM

This revision was automatically updated to reflect the committed changes.

royger added a commit: rG7d3259775cb6: stand/efi: add modulep to kernel metadata.

This appears to have broken the AArch64 build for me:

/local/scratch/alr48/cheri/freebsd/stand/efi/loader_4th/../loader/bootinfo.c:535:24: error: use of undeclared identifier 'MODINFOMD_MODULEP'
        file_addmetadata(kfp, MODINFOMD_MODULEP, sizeof(module), &module);

imp added a commit: rG8f6f1e27fd18: stand/efi: add modulep to kernel metadata.Jan 24 2023, 10:10 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 24 2023, 10:10 PM

Herald added a subscriber: dab. · View Herald Transcript