Stop passing MK_WARNS=no for bootstrap tools
ClosedPublic
Actions

Authored by arichardson on Dec 13 2020, 5:12 PM.

Details

Reviewers

imp
jhb
brooks
emaste

Commits

rG94ffff68c8e8: Stop passing MK_WARNS=no for bootstrap tools

Summary

I got annoyed by the number of warnings that the CheriBSD build was
emitting. It turns out that we are emitting lots of warnings during
bootstrap because bootstrap tools are built with the default compiler
flags and ignore the warnings flags that are set in bsd.sys.mk.

Looking at git blame, it appears that MK_WARNS=no has been passed since
rS112869, replacing the -DNO_WERROR option that was added in rS87775.

This commit changes MK_WARNS=no back to -DNO_WERROR. We need to pass
-DNO_WERROR, since the system compiler might have new warnings that we
don't know about yet, and we shouldn't fail the build in that case.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35382
Build 32301: arc lint + arc unit

Event Timeline

arichardson created this revision.Dec 13 2020, 5:12 PM

arichardson published this revision for review.Dec 13 2020, 5:14 PM

Harbormaster completed remote builds in B35382: Diff 80664.Dec 13 2020, 5:14 PM

arichardson mentioned this in D27599: Fix all warnings emitted in `make kernel-toolchain`.Dec 13 2020, 5:21 PM

In an ideal world, we'd have MK_WERROR={yes,no} and this would be WITHOUT_WERROR for users or MK_WERROR=no internally.
But this is better enough I'm clicking approve, though if you wanted to do this idea I'd be happier.

This revision is now accepted and ready to land.Dec 13 2020, 6:31 PM

In D27598#616727, @imp wrote:

In an ideal world, we'd have MK_WERROR={yes,no} and this would be WITHOUT_WERROR for users or MK_WERROR=no internally.
But this is better enough I'm clicking approve, though if you wanted to do this idea I'd be happier.

Will open a follow-up revision. There are a few more places that need a NO_WERROR -> MK_WERROR=no change and I'd rather do that in a separate commit.

arichardson mentioned this in D27601: Rename NO_WERROR -> MK_WERROR=no.Dec 13 2020, 6:49 PM

arichardson added a child revision: D27601: Rename NO_WERROR -> MK_WERROR=no.Dec 13 2020, 6:51 PM

Separate commit is fine

brooks accepted this revision.Dec 14 2020, 6:45 PM

Closed by commit rG94ffff68c8e8: Stop passing MK_WARNS=no for bootstrap tools (authored by arichardson). · Explain WhyJan 7 2021, 11:08 AM

This revision was automatically updated to reflect the committed changes.

arichardson mentioned this in rGed8455806e88: Fix all warnings emitted in `make kernel-toolchain`.

arichardson mentioned this in rG4e64fb9f4901: Fix warnings during bootstrap on Linux systems.

arichardson added a commit: rG94ffff68c8e8: Stop passing MK_WARNS=no for bootstrap tools.

arichardson mentioned this in rG7fa2f2a62f04: Rename NO_WERROR -> MK_WERROR=no.