sanity: warn about unnused LIB_DEPENDS entries
ClosedPublic
Actions

Authored by tcberner on Nov 21 2020, 9:57 AM.

Details

Reviewers

mat

Group Reviewers

portmgr

Commits

R11:f3790c0170d8: sanity: warn about unnused LIB_DEPENDS entries

Summary

This might be a bad idea, and certainly not a great implementation :) ...

stage-qa already warns about missing dependencies. However, it does not warn
about possibly unneeded ones.

This change tries to address this, by simply walking the list of linked against
shared libraries and then matching the entries of LIB_DEPENDS against them.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 34943
Build 31955: arc lint + arc unit

Event Timeline

tcberner requested review of this revision.Nov 21 2020, 9:57 AM

tcberner created this revision.

Harbormaster completed remote builds in B34943: Diff 79828.Nov 21 2020, 9:57 AM

adridg mentioned this in R11:c0f139b89306: */kf5-*: (KDE Frameworks) lighten dependencies.Jul 9 2021, 5:36 PM

grahamperrin added a subscriber: grahamperrin.Sep 6 2022, 2:48 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2023, 6:32 PM

Closed by commit R11:f3790c0170d8: sanity: warn about unnused LIB_DEPENDS entries (authored by tcberner). · Explain Why

This revision was automatically updated to reflect the committed changes.

tcberner added a commit: R11:f3790c0170d8: sanity: warn about unnused LIB_DEPENDS entries.

Revision Contents
Changeset List

Path

Size

Mk/

Scripts/

qa.sh

11 lines

bsd.port.mk

1 line

Diff 79828

View Options

Mk/Scripts/qa.sh