Paths

Table of Contentst

Differential D20745

Remove NAND and NANDFS support
ClosedPublic
Actions

Authored by imp on Jun 24 2019, 4:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 22 2024, 8:53 PM

	Unknown Object (File)
	Nov 22 2024, 7:32 AM

	Unknown Object (File)
	Nov 19 2024, 1:32 PM

	Unknown Object (File)
	Nov 15 2024, 11:09 AM

	Unknown Object (File)
	Nov 8 2024, 3:21 AM

	Unknown Object (File)
	Nov 7 2024, 9:59 AM

	Unknown Object (File)
	Oct 31 2024, 12:43 AM

	Unknown Object (File)
	Oct 22 2024, 8:41 PM

Subscribers

Details

Reviewers

None

Group Reviewers

manpages
bhyve

Commits

rS349352: Remove NAND and NANDFS support

Summary

NANDFS has been broken for years. Remove it. The NAND drivers that
remain are for ancient parts that are no longer relevant. They are
polled, have terrible performance and just for ancient arm
hardware. NAND parts have evolved significantly from this early work
and little to none of it would be relevant should someone need to
update to support raw nand.

Numerous posts to arch@ and other locations have found no actual users
for this software.

Relnotes: Yes
No Objection From: arch@

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25009
Build 23724: arc lint + arc unit

Event Timeline

imp created this revision.Jun 24 2019, 4:33 PM

Herald added subscribers: emaste, andrew, bdrewery. · View Herald TranscriptJun 24 2019, 4:33 PM

Harbormaster completed remote builds in B25008: Diff 58957.Jun 24 2019, 4:33 PM

emaste added inline comments.Jun 24 2019, 4:48 PM

stand/common/part.c
94	Should these be kept? (perhaps as "`FreeBSD nandfs (obsolete)`"?)

imp added inline comments.Jun 24 2019, 5:13 PM

stand/common/part.c
94	No. this stuff hasn't worked in years and years (a decade? ever?). It's better to just kill it imho. There's a vanishingly small user base for it (zero I'd wager) and I'd rather just completely eliminate it.

Missed references.

Harbormaster completed remote builds in B25009: Diff 58958.Jun 24 2019, 5:25 PM

tobik mentioned this in rP505321: Convert all Go ports to USES=go.Jun 29 2019, 3:51 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 5 2019, 8:43 PM

Closed by commit rS349352: Remove NAND and NANDFS support (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS349352: Remove NAND and NANDFS support.

Herald added a reviewer: manpages. · View Herald TranscriptJul 5 2019, 8:43 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: bcran, jonathan, rgrimes. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

etc/

mtree/

BSD.include.dist

4 lines

include/

20 lines

lib/

1 line

libnandfs/

Makefile.depend

sbin/

2 lines

nandfs/

Makefile.depend

newfs_nandfs/

Makefile.depend

share/

man/

man4/

2 lines

man5/

4 lines

mk/

bsd.libnames.mk

1 line

src.libnames.mk

1 line

1 line

stand/

arm/

uboot/

3 lines

1 line

common/

1 line

8 lines

i386/

loader/

3 lines

libsa/

3 lines

1 line

3 lines

mips/

uboot/

3 lines

1 line

sys/

arm/

conf/

3 lines

3 lines

8 lines

5 lines

3 lines

3 lines

freescale/

vybrid/

mv/

1 line

1 line

conf/

33 lines

2 lines

1 line

dev/

nand/

fs/

nandfs/

nandfs_buffer.c

nandfs_cleaner.c

nandfs_cpfile.c

nandfs_segment.c

nandfs_sufile.c

nandfs_vfsops.c

geom/

geom_flashmap.c

2 lines

modules/

7 lines

nand/

nandfs/

nandsim/

targets/

pseudo/

userland/

Makefile.depend

9 lines

lib/

Makefile.depend

4 lines

usr.sbin/

2 lines

nandsim/

Makefile.depend

nandsim_cfgparse.h

nandsim_cfgparse.c

nandsim_rcfile.h

nandsim_rcfile.c

nandtool/

Makefile.depend

nand_writeoob.c

Diff 58958

etc/mtree/BSD.include.dist

Loading...

include/Makefile

Loading...

lib/Makefile

Loading...

lib/libnandfs/Makefile

Loading...

lib/libnandfs/Makefile.depend

Loading...

lib/libnandfs/libnandfs.h

Loading...

lib/libnandfs/nandfs.c

Loading...

sbin/Makefile

Loading...

sbin/nandfs/Makefile

Loading...

sbin/nandfs/Makefile.depend

Loading...

sbin/nandfs/lssnap.c

Loading...

sbin/nandfs/mksnap.c

Loading...

sbin/nandfs/nandfs.h

Loading...

sbin/nandfs/nandfs.8

Loading...

sbin/nandfs/nandfs.c

Loading...

sbin/nandfs/rmsnap.c

Loading...

sbin/newfs_nandfs/Makefile

Loading...

sbin/newfs_nandfs/Makefile.depend

Loading...

sbin/newfs_nandfs/newfs_nandfs.8

Loading...

sbin/newfs_nandfs/newfs_nandfs.c

Loading...

share/man/man4/Makefile

Loading...

share/man/man4/nand.4

Loading...

share/man/man4/nandsim.4

Loading...

share/man/man5/Makefile

Loading...

share/man/man5/nandfs.5

Loading...

share/mk/bsd.libnames.mk

Loading...

share/mk/src.libnames.mk

Loading...

share/mk/src.opts.mk

Loading...

stand/arm/uboot/conf.c

Loading...

stand/arm/uboot/version

Loading...

stand/common/part.h

Loading...

stand/common/part.c

Loading...

stand/i386/loader/conf.c

Loading...

stand/libsa/Makefile

Loading...

stand/libsa/nandfs.c

Loading...

stand/libsa/stand.h

Loading...

stand/loader.mk

Loading...

stand/mips/uboot/conf.c

Loading...

stand/mips/uboot/version

Loading...

sys/arm/conf/DB-78XXX

Loading...

sys/arm/conf/DB-88F6XXX

Loading...

sys/arm/conf/DREAMPLUG-1001

Loading...

sys/arm/conf/NOTES.armv5

Loading...

sys/arm/conf/SHEEVAPLUG

Loading...

sys/arm/conf/VYBRID

Loading...

sys/arm/freescale/vybrid/vf_nfc.c

Loading...

sys/arm/mv/files.arm7

Loading...

sys/arm/mv/files.mv

Loading...

sys/conf/files

Loading...

sys/conf/files.powerpc

Loading...

sys/conf/kern.opts.mk

Loading...

sys/dev/nand/nand.h

Loading...

sys/dev/nand/nand.c

Loading...

sys/dev/nand/nand_bbt.c

Loading...

sys/dev/nand/nand_cdev.c

Loading...

sys/dev/nand/nand_dev.h

Loading...

sys/dev/nand/nand_ecc_pos.h

Loading...

sys/dev/nand/nand_generic.c

Loading...

sys/dev/nand/nand_geom.c

Loading...

sys/dev/nand/nand_id.c

Loading...

sys/dev/nand/nand_if.m

Loading...

sys/dev/nand/nandbus.h

Loading...

sys/dev/nand/nandbus.c

Loading...

sys/dev/nand/nandbus_if.m

Loading...

sys/dev/nand/nandsim.h

Loading...

sys/dev/nand/nandsim.c

Loading...

sys/dev/nand/nandsim_chip.h

Loading...

sys/dev/nand/nandsim_chip.c

Loading...

sys/dev/nand/nandsim_ctrl.c

Loading...

sys/dev/nand/nandsim_log.h

Loading...

sys/dev/nand/nandsim_log.c

Loading...

sys/dev/nand/nandsim_swap.h

Loading...

sys/dev/nand/nandsim_swap.c

Loading...

sys/dev/nand/nfc_fsl.h

Loading...

sys/dev/nand/nfc_fsl.c

Loading...

sys/dev/nand/nfc_if.m

Loading...

sys/dev/nand/nfc_mv.c

Loading...

sys/dev/nand/nfc_rb.c

Loading...

sys/fs/nandfs/bmap.h

Loading...

sys/fs/nandfs/bmap.c

Loading...

sys/fs/nandfs/nandfs.h

Loading...

sys/fs/nandfs/nandfs_alloc.c

Loading...

sys/fs/nandfs/nandfs_bmap.c

Loading...

sys/fs/nandfs/nandfs_buffer.c

Loading...

sys/fs/nandfs/nandfs_cleaner.c

Loading...

sys/fs/nandfs/nandfs_cpfile.c

Loading...

sys/fs/nandfs/nandfs_dat.c

Loading...

sys/fs/nandfs/nandfs_dir.c

Loading...

sys/fs/nandfs/nandfs_fs.h

Loading...

sys/fs/nandfs/nandfs_ifile.c

Loading...

sys/fs/nandfs/nandfs_mount.h

Loading...

sys/fs/nandfs/nandfs_segment.c

Loading...

sys/fs/nandfs/nandfs_subr.h

Loading...

sys/fs/nandfs/nandfs_subr.c

Loading...

sys/fs/nandfs/nandfs_sufile.c

Loading...

sys/fs/nandfs/nandfs_vfsops.c

Loading...

sys/fs/nandfs/nandfs_vnops.c

Loading...

sys/geom/geom_flashmap.c

Loading...

sys/modules/Makefile

Loading...

sys/modules/nand/Makefile

Loading...

sys/modules/nandfs/Makefile

Loading...

sys/modules/nandsim/Makefile

Loading...

targets/pseudo/userland/Makefile.depend

Loading...

targets/pseudo/userland/lib/Makefile.depend

Loading...

usr.sbin/Makefile

Loading...

usr.sbin/nandsim/Makefile

Loading...

usr.sbin/nandsim/Makefile.depend

Loading...

usr.sbin/nandsim/nandsim.8

Loading...

usr.sbin/nandsim/nandsim.c

Loading...

usr.sbin/nandsim/nandsim_cfgparse.h

Loading...

usr.sbin/nandsim/nandsim_cfgparse.c

Loading...

usr.sbin/nandsim/nandsim_rcfile.h

Loading...

usr.sbin/nandsim/nandsim_rcfile.c

Loading...

usr.sbin/nandsim/sample.conf

Loading...

usr.sbin/nandtool/Makefile

Loading...

usr.sbin/nandtool/Makefile.depend

Loading...

usr.sbin/nandtool/nand_erase.c

Loading...

usr.sbin/nandtool/nand_info.c

Loading...

usr.sbin/nandtool/nand_read.c

Loading...

usr.sbin/nandtool/nand_readoob.c

Loading...

usr.sbin/nandtool/nand_write.c

Loading...

usr.sbin/nandtool/nand_writeoob.c

Loading...

usr.sbin/nandtool/nandtool.h

Loading...

usr.sbin/nandtool/nandtool.8

Loading...

usr.sbin/nandtool/nandtool.c

Loading...

usr.sbin/nandtool/usage.h

Loading...