Paths

Table of Contentst

Differential D20745

Remove NAND and NANDFS support
ClosedPublic
Actions

Authored by imp on Jun 24 2019, 4:33 PM.

Tags

None

Referenced Files

	F107698660: D20745.lt.diff
	Fri, Jan 17, 3:54 PM

	F107683166: D20745.diff
	Fri, Jan 17, 1:35 PM

	Unknown Object (File)
	Sun, Jan 5, 6:03 AM

	Unknown Object (File)
	Nov 22 2024, 8:53 PM

	Unknown Object (File)
	Nov 22 2024, 7:32 AM

	Unknown Object (File)
	Nov 19 2024, 1:32 PM

	Unknown Object (File)
	Nov 15 2024, 11:09 AM

	Unknown Object (File)
	Nov 8 2024, 3:21 AM

Subscribers

Details

Reviewers

None

Group Reviewers

manpages
bhyve

Commits

rS349352: Remove NAND and NANDFS support

Summary

NANDFS has been broken for years. Remove it. The NAND drivers that
remain are for ancient parts that are no longer relevant. They are
polled, have terrible performance and just for ancient arm
hardware. NAND parts have evolved significantly from this early work
and little to none of it would be relevant should someone need to
update to support raw nand.

Numerous posts to arch@ and other locations have found no actual users
for this software.

Relnotes: Yes
No Objection From: arch@

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jun 24 2019, 4:33 PM

Herald added subscribers: emaste, andrew, bdrewery. · View Herald TranscriptJun 24 2019, 4:33 PM

Harbormaster completed remote builds in B25008: Diff 58957.Jun 24 2019, 4:33 PM

emaste added inline comments.Jun 24 2019, 4:48 PM

stand/common/part.c
94 ↗	(On Diff #58957)	Should these be kept? (perhaps as "`FreeBSD nandfs (obsolete)`"?)

imp added inline comments.Jun 24 2019, 5:13 PM

stand/common/part.c
94 ↗	(On Diff #58957)	No. this stuff hasn't worked in years and years (a decade? ever?). It's better to just kill it imho. There's a vanishingly small user base for it (zero I'd wager) and I'd rather just completely eliminate it.

Missed references.

Harbormaster completed remote builds in B25009: Diff 58958.Jun 24 2019, 5:25 PM

tobik mentioned this in rP505321: Convert all Go ports to USES=go.Jun 29 2019, 3:51 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 5 2019, 8:43 PM

Closed by commit rS349352: Remove NAND and NANDFS support (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS349352: Remove NAND and NANDFS support.

Herald added a reviewer: manpages. · View Herald TranscriptJul 5 2019, 8:43 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: bcran, jonathan, rgrimes. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

etc/

mtree/

BSD.include.dist

4 lines

include/

20 lines

lib/

1 line

libnandfs/

10 lines

Makefile.depend

17 lines

67 lines

249 lines

sbin/

2 lines

camcontrol/

24 lines

nandfs/

10 lines

Makefile.depend

18 lines

114 lines

82 lines

42 lines

79 lines

76 lines

89 lines

newfs_nandfs/

9 lines

Makefile.depend

20 lines

74 lines

1183 lines

share/

man/

man4/

2 lines

145 lines

93 lines

man5/

4 lines

132 lines

mk/

bsd.libnames.mk

1 line

src.libnames.mk

1 line

1 line

stand/

arm/

uboot/

3 lines

1 line

common/

1 line

8 lines

i386/

loader/

3 lines

libsa/

3 lines

1061 lines

1 line

3 lines

mips/

uboot/

3 lines

1 line

sys/

arm/

conf/

3 lines

3 lines

8 lines

5 lines

3 lines

3 lines

freescale/

vybrid/

528 lines

mv/

1 line

1 line

cam/

ata/

1 line

25 lines

23 lines

scsi/

19 lines

conf/

33 lines

2 lines

1 line

dev/

nand/

415 lines

826 lines

275 lines

454 lines

92 lines

58 lines

1366 lines

467 lines

70 lines

168 lines

51 lines

542 lines

100 lines

177 lines

670 lines

161 lines

898 lines

398 lines

54 lines

188 lines

66 lines

383 lines

99 lines

717 lines

165 lines

238 lines

321 lines

fs/

nandfs/

42 lines

625 lines

312 lines

366 lines

232 lines

nandfs_buffer.c

85 lines

nandfs_cleaner.c

622 lines

nandfs_cpfile.c

778 lines

346 lines

316 lines

567 lines

215 lines

52 lines

nandfs_segment.c

1314 lines

240 lines

1091 lines

nandfs_sufile.c

571 lines

nandfs_vfsops.c

1601 lines

2454 lines

smbfs/

4 lines

geom/

geom_flashmap.c

24 lines

modules/

7 lines

nand/

10 lines

nandfs/

12 lines

nandsim/

9 lines

sys/

2 lines

targets/

pseudo/

userland/

Makefile.depend

9 lines

lib/

Makefile.depend

4 lines

usr.bin/

vtfontcvt/

13 lines

usr.sbin/

2 lines

bhyve/

3 lines

86 lines

282 lines

14 lines

950 lines

1367 lines

269 lines

90 lines

1330 lines

nandsim/

8 lines

Makefile.depend

17 lines

229 lines

1399 lines

nandsim_cfgparse.h

88 lines

nandsim_cfgparse.c

961 lines

nandsim_rcfile.h

72 lines

nandsim_rcfile.c

442 lines

174 lines

nandtool/

10 lines

Makefile.depend

20 lines

116 lines

88 lines

141 lines

113 lines

145 lines

nand_writeoob.c

115 lines

59 lines

184 lines

285 lines

114 lines

Diff 59453

head/etc/mtree/BSD.include.dist

Loading...

head/include/Makefile

Loading...

head/lib/Makefile

Loading...

head/lib/libnandfs/Makefile

Loading...

head/lib/libnandfs/Makefile.depend

Loading...

head/lib/libnandfs/libnandfs.h

Loading...

head/lib/libnandfs/nandfs.c

Loading...

head/sbin/Makefile

Loading...

head/sbin/camcontrol/camcontrol.c

Loading...

head/sbin/nandfs/Makefile

Loading...

head/sbin/nandfs/Makefile.depend

Loading...

head/sbin/nandfs/lssnap.c

Loading...

head/sbin/nandfs/mksnap.c

Loading...

head/sbin/nandfs/nandfs.h

Loading...

head/sbin/nandfs/nandfs.8

Loading...

head/sbin/nandfs/nandfs.c

Loading...

head/sbin/nandfs/rmsnap.c

Loading...

head/sbin/newfs_nandfs/Makefile

Loading...

head/sbin/newfs_nandfs/Makefile.depend

Loading...

head/sbin/newfs_nandfs/newfs_nandfs.8

Loading...

head/sbin/newfs_nandfs/newfs_nandfs.c

Loading...

head/share/man/man4/Makefile

Loading...

head/share/man/man4/nand.4

Loading...

head/share/man/man4/nandsim.4

Loading...

head/share/man/man5/Makefile

Loading...

head/share/man/man5/nandfs.5

Loading...

head/share/mk/bsd.libnames.mk

Loading...

head/share/mk/src.libnames.mk

Loading...

head/share/mk/src.opts.mk

Loading...

head/stand/arm/uboot/conf.c

Loading...

head/stand/arm/uboot/version

Loading...

head/stand/common/part.h

Loading...

head/stand/common/part.c

Loading...

head/stand/i386/loader/conf.c

Loading...

head/stand/libsa/Makefile

Loading...

head/stand/libsa/nandfs.c

Loading...

head/stand/libsa/stand.h

Loading...

head/stand/loader.mk

Loading...

head/stand/mips/uboot/conf.c

Loading...

head/stand/mips/uboot/version

Loading...

head/sys/arm/conf/DB-78XXX

Loading...

head/sys/arm/conf/DB-88F6XXX

Loading...

head/sys/arm/conf/DREAMPLUG-1001

Loading...

head/sys/arm/conf/NOTES.armv5

Loading...

head/sys/arm/conf/SHEEVAPLUG

Loading...

head/sys/arm/conf/VYBRID

Loading...

head/sys/arm/freescale/vybrid/vf_nfc.c

Loading...

head/sys/arm/mv/files.arm7

Loading...

head/sys/arm/mv/files.mv

Loading...

head/sys/cam/ata/ata_all.h

Loading...

head/sys/cam/ata/ata_all.c

Loading...

head/sys/cam/ata/ata_xpt.c

Loading...

head/sys/cam/scsi/scsi_da.c

Loading...

head/sys/conf/files

Loading...

head/sys/conf/files.powerpc

Loading...

head/sys/conf/kern.opts.mk

Loading...

head/sys/dev/nand/nand.h

Loading...

head/sys/dev/nand/nand.c

Loading...

head/sys/dev/nand/nand_bbt.c

Loading...

head/sys/dev/nand/nand_cdev.c

Loading...

head/sys/dev/nand/nand_dev.h

Loading...

head/sys/dev/nand/nand_ecc_pos.h

Loading...

head/sys/dev/nand/nand_generic.c

Loading...

head/sys/dev/nand/nand_geom.c

Loading...

head/sys/dev/nand/nand_id.c

Loading...

head/sys/dev/nand/nand_if.m

Loading...

head/sys/dev/nand/nandbus.h

Loading...

head/sys/dev/nand/nandbus.c

Loading...

head/sys/dev/nand/nandbus_if.m

Loading...

head/sys/dev/nand/nandsim.h

Loading...

head/sys/dev/nand/nandsim.c

Loading...

head/sys/dev/nand/nandsim_chip.h

Loading...

head/sys/dev/nand/nandsim_chip.c

Loading...

head/sys/dev/nand/nandsim_ctrl.c

Loading...

head/sys/dev/nand/nandsim_log.h

Loading...

head/sys/dev/nand/nandsim_log.c

Loading...

head/sys/dev/nand/nandsim_swap.h

Loading...

head/sys/dev/nand/nandsim_swap.c

Loading...

head/sys/dev/nand/nfc_fsl.h

Loading...

head/sys/dev/nand/nfc_fsl.c

Loading...

head/sys/dev/nand/nfc_if.m

Loading...

head/sys/dev/nand/nfc_mv.c

Loading...

head/sys/dev/nand/nfc_rb.c

Loading...

head/sys/fs/nandfs/bmap.h

Loading...

head/sys/fs/nandfs/bmap.c

Loading...

head/sys/fs/nandfs/nandfs.h

Loading...

head/sys/fs/nandfs/nandfs_alloc.c

Loading...

head/sys/fs/nandfs/nandfs_bmap.c

Loading...

head/sys/fs/nandfs/nandfs_buffer.c

Loading...

head/sys/fs/nandfs/nandfs_cleaner.c

Loading...

head/sys/fs/nandfs/nandfs_cpfile.c

Loading...

head/sys/fs/nandfs/nandfs_dat.c

Loading...

head/sys/fs/nandfs/nandfs_dir.c

Loading...

head/sys/fs/nandfs/nandfs_fs.h

Loading...

head/sys/fs/nandfs/nandfs_ifile.c

Loading...

head/sys/fs/nandfs/nandfs_mount.h

Loading...

head/sys/fs/nandfs/nandfs_segment.c

Loading...

head/sys/fs/nandfs/nandfs_subr.h

Loading...

head/sys/fs/nandfs/nandfs_subr.c

Loading...

head/sys/fs/nandfs/nandfs_sufile.c

Loading...

head/sys/fs/nandfs/nandfs_vfsops.c

Loading...

head/sys/fs/nandfs/nandfs_vnops.c

Loading...

head/sys/fs/smbfs/smbfs_io.c

Loading...

head/sys/geom/geom_flashmap.c

Loading...

head/sys/modules/Makefile

Loading...

head/sys/modules/nand/Makefile

Loading...

head/sys/modules/nandfs/Makefile

Loading...

head/sys/modules/nandsim/Makefile

Loading...

head/sys/sys/param.h

Loading...

head/targets/pseudo/userland/Makefile.depend

Loading...

head/targets/pseudo/userland/lib/Makefile.depend

Loading...

head/usr.bin/vtfontcvt/vtfontcvt.c

Loading...

head/usr.sbin/Makefile

Loading...

head/usr.sbin/bhyve/Makefile

Loading...

head/usr.sbin/bhyve/audio.h

Loading...

head/usr.sbin/bhyve/audio.c

Loading...

head/usr.sbin/bhyve/bhyve.8

Loading...

head/usr.sbin/bhyve/hda_codec.c

Loading...

head/usr.sbin/bhyve/hda_reg.h

Loading...

head/usr.sbin/bhyve/hdac_reg.h

Loading...

head/usr.sbin/bhyve/pci_hda.h

Loading...

head/usr.sbin/bhyve/pci_hda.c

Loading...

head/usr.sbin/nandsim/Makefile

Loading...

head/usr.sbin/nandsim/Makefile.depend

Loading...

head/usr.sbin/nandsim/nandsim.8

Loading...

head/usr.sbin/nandsim/nandsim.c

Loading...

head/usr.sbin/nandsim/nandsim_cfgparse.h

Loading...

head/usr.sbin/nandsim/nandsim_cfgparse.c

Loading...

head/usr.sbin/nandsim/nandsim_rcfile.h

Loading...

head/usr.sbin/nandsim/nandsim_rcfile.c

Loading...

head/usr.sbin/nandsim/sample.conf

Loading...

head/usr.sbin/nandtool/Makefile

Loading...

head/usr.sbin/nandtool/Makefile.depend

Loading...

head/usr.sbin/nandtool/nand_erase.c

Loading...

head/usr.sbin/nandtool/nand_info.c

Loading...

head/usr.sbin/nandtool/nand_read.c

Loading...

head/usr.sbin/nandtool/nand_readoob.c

Loading...

head/usr.sbin/nandtool/nand_write.c

Loading...

head/usr.sbin/nandtool/nand_writeoob.c

Loading...

head/usr.sbin/nandtool/nandtool.h

Loading...

head/usr.sbin/nandtool/nandtool.8

Loading...

head/usr.sbin/nandtool/nandtool.c

Loading...

head/usr.sbin/nandtool/usage.h

Loading...