Paths

Table of Contentst

Differential D50352

build: Emit a warning for build targets run as root
ClosedPublic
Actions

Authored by emaste on May 14 2025, 3:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 9, 9:40 PM

	Unknown Object (File)
	Fri, Oct 9, 4:54 PM

	Unknown Object (File)
	Fri, Oct 9, 4:53 PM

	Unknown Object (File)
	Fri, Oct 9, 4:53 PM

	Unknown Object (File)
	Wed, Oct 7, 7:18 AM

	Unknown Object (File)
	Tue, Sep 29, 11:32 PM

	Unknown Object (File)
	Tue, Sep 29, 11:54 AM

	Unknown Object (File)
	Sep 10 2026, 10:26 PM

View All 73 Files

Subscribers

Details

Reviewers

brooks
adrian

Group Reviewers

Commits

rG24d5194306b5: build: Emit a warning for build targets run as root

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.May 14 2025, 3:25 PM

emaste created this revision.

emaste added a reviewer: build.Apr 29 2026, 6:15 PM

We should really make it an error with an annoyingly long override.

This revision is now accepted and ready to land.Fri, Oct 9, 2:44 PM

adrian accepted this revision.Fri, Oct 9, 3:04 PM

Closed by commit rG24d5194306b5: build: Emit a warning for build targets run as root (authored by emaste). · Explain WhyFri, Oct 9, 3:05 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG24d5194306b5: build: Emit a warning for build targets run as root.

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 3:05 PM

We do this as root at work, so this will just add noise (since nanobsd doesn't have privsep)

ngie added a subscriber: ngie.Fri, Oct 9, 6:42 PM

ngie added inline comments.

Makefile.inc1
378–379	Is this really the best spot to do this? This will emit a bunch more noise for each top-level argument executed and does a bunch more forks than necessary. I would think the top-level Makefile would be a lot better.
380	The `Warning:` prefix is superfluous: % cat f.mk .warning "Warning: foo" % bmake -f f.mk bmake: /usr/src/tests/sys/fs/fusefs/f.mk:1: warning: "Warning: foo" bmake: no target to make. bmake: stopped in /usr/src/tests/sys/fs/fusefs

emaste added inline comments.Fri, Oct 9, 7:25 PM

Makefile.inc1
378–379	I'll take a look. Note that this is in the section for build targets so won't be run unconditionally.
380	Yes the extra "Warning" needs to be removed. I'll leave it for now while we decide between reverting, demoting to .info, moving, etc.

Revision Contents
Changeset List

Path

Size

4 lines

Diff 189249

Makefile.inc1

Loading...