Page MenuHomeFreeBSD
Differential D58027

x86: add AMD RAPL MSR definitions to specialreg.h
ClosedPublic
Actions

Authored by afscoelho_gmail.com on Jul 3 2026, 6:00 PM.
Tags
None
Referenced Files
F166863117: D58027.id182818.diff
Mon, Aug 17, 6:33 AM
Unknown Object (File)
Wed, Aug 12, 11:32 PM
Unknown Object (File)
Sun, Aug 9, 7:35 PM
Unknown Object (File)
Sun, Aug 9, 4:42 AM
Unknown Object (File)
Sat, Aug 8, 6:52 PM
Unknown Object (File)
Sat, Aug 8, 3:50 PM
Unknown Object (File)
Sat, Aug 8, 3:47 PM
Unknown Object (File)
Sat, Aug 8, 4:56 AM
View All 32 Files
Subscribers
aokblast
imp

Details

Reviewers
ali_mashtizadeh.com
gnn
mhorne
alfredo
janeri_gmail.com
raghavendra.kt_amd.com
adrian
Group Reviewers
pmc
Commits
rG77404ee1e99d: x86: add AMD RAPL MSR definitions to specialreg.h
Summary

specialreg.h is the tree's MSR registry and already carries the Intel
RAPL group. Add the AMD RAPL package/core energy and unit MSRs here so
the hwpmc RAPL class can reference them without a private driver copy.
Use the names Linux's msr-index.h gives these registers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75176
Build 72059: arc lint + arc unit

Event Timeline

afscoelho_gmail.com created this revision.Jul 3 2026, 6:00 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 3 2026, 6:00 PM
afscoelho_gmail.com requested review of this revision.Jul 3 2026, 6:00 PM
afscoelho_gmail.com added a child revision: D58028: hwpmc: add RAPL energy-counter class (AMD + Intel).
Harbormaster completed remote builds in B74509: Diff 181266.Jul 3 2026, 6:00 PM
afscoelho_gmail.com added reviewers: gnn, mhorne, alfredo, janeri_gmail.com, raghavendra.kt_amd.com, pmc.Jul 3 2026, 6:18 PM
afscoelho_gmail.com mentioned this in D55603: amdrapl: Introduce amdrapl driver.Jul 3 2026, 6:30 PM
ali_mashtizadeh.com accepted this revision.Jul 9 2026, 6:22 PM
This revision is now accepted and ready to land.Jul 9 2026, 6:22 PM
adrian accepted this revision.Jul 9 2026, 6:43 PM
mhorne accepted this revision.Jul 17 2026, 5:19 PM
aokblast added a subscriber: aokblast.EditedSat, Jul 25, 1:45 PM

hi, it would be better to commit D57759, right? I can commit that patch for you.

afscoelho_gmail.com added a comment.Mon, Jul 27, 6:36 PM

Hi, thanks for the offer. I would prefer not to commit D57759. I plan to discard it and continue with D58027 as part of the current hwpmc RAPL stack, since D58027 has the structure I want for this work

afscoelho_gmail.com updated this revision to Diff 182818.Mon, Jul 27, 7:10 PM
This revision now requires review to proceed.Mon, Jul 27, 7:10 PM
Harbormaster completed remote builds in B75176: Diff 182818.Mon, Jul 27, 7:10 PM
aokblast added a comment.Tue, Jul 28, 4:24 AM

Ok! I would like to confirm something with you before committing:

  1. Author info: Andre Silva <andasilv@amd.com>
  2. Sponsored by: Advanced Micro Devices (AMD)

Are the both desired information you expected?

afscoelho_gmail.com added a comment.Tue, Jul 28, 1:58 PM
In D58027#1342399, @aokblast wrote:

Ok! I would like to confirm something with you before committing:

  1. Author info: Andre Silva <andasilv@amd.com>
  2. Sponsored by: Advanced Micro Devices (AMD)

Are the both desired information you expected?

Yes, they are. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jul 28, 3:02 PM
Closed by commit rG77404ee1e99d: x86: add AMD RAPL MSR definitions to specialreg.h (authored by afscoelho_gmail.com, committed by mhorne). · Explain Why
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG77404ee1e99d: x86: add AMD RAPL MSR definitions to specialreg.h.
mhorne added a comment.Tue, Jul 28, 3:03 PM
In D58027#1342622, @afscoelho_gmail.com wrote:
In D58027#1342399, @aokblast wrote:

Ok! I would like to confirm something with you before committing:

  1. Author info: Andre Silva <andasilv@amd.com>
  2. Sponsored by: Advanced Micro Devices (AMD)

Are the both desired information you expected?

Yes, they are. Thanks!

Sorry to interfere @aokblast, but I was ready to commit the whole series and just did so.

aokblast added a comment.Wed, Jul 29, 12:27 AM
In D58027#1342667, @mhorne wrote:
In D58027#1342622, @afscoelho_gmail.com wrote:
In D58027#1342399, @aokblast wrote:

Ok! I would like to confirm something with you before committing:

  1. Author info: Andre Silva <andasilv@amd.com>
  2. Sponsored by: Advanced Micro Devices (AMD)

Are the both desired information you expected?

Yes, they are. Thanks!

Sorry to interfere @aokblast, but I was ready to commit the whole series and just did so.

Sure. It is fine. I just want to make sure who contributes FreeBSD spend much time on waiting.

afscoelho_gmail.com mentioned this in D57759: x86: add AMD RAPL MSR and feature-bit definitions.Fri, Jul 31, 4:28 PM

Revision Contents
Changeset List

PathSize
sys/
x86/
include/
3 lines

Diff 182818

View Options

sys/x86/include/specialreg.h

Loading...