acpi_einj: Support for ACPI error injection
ClosedPublic
Actions

Authored by jhb on Fri, Jul 3, 4:01 PM.

Details

Reviewers

imp
gallatin
mav
jkim

Commits

rGbc49842769bd: acpi_einj: Support for ACPI error injection

Summary

This driver parses the ACPI EINJ table and builds a list of
instructions associated with known actions. It then exports ioctls to
fetch the set of supported errors and inject system errors by
executing specific sequences of actions. This can be used to test
error reporting facilities for events such as ECC errors.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74506
Build 71389: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, Jul 3, 4:01 PM

Herald added a subscriber: ziaee. · View Herald TranscriptFri, Jul 3, 4:01 PM

jhb requested review of this revision.Fri, Jul 3, 4:01 PM

jhb added a parent revision: D58024: acpi: Add a pseudo-bus for APEI devices to manage resources.

Harbormaster completed remote builds in B74502: Diff 181258.Fri, Jul 3, 4:01 PM

jhb added a child revision: D58026: einj: Tool to manage APEI error injection.Fri, Jul 3, 4:01 PM

Fix order of operands to copyout for the vendor structure and add apei_if.h
to the module Makefile (noted by Claude)

Harbormaster completed remote builds in B74506: Diff 181262.Fri, Jul 3, 4:25 PM

gallatin accepted this revision.Fri, Jul 3, 5:30 PM

gallatin added inline comments.

sys/dev/acpica/acpi_einj.c
149	Would be nice to have more data about the expected vs actual data in all these cases. Should be harmless to be chatty, since its under bootverbose, and might reduce round-trips when triaging issues with this.

This revision is now accepted and ready to land.Fri, Jul 3, 5:30 PM

jhb added inline comments.Fri, Jul 3, 6:37 PM

sys/dev/acpica/acpi_einj.c
149	Hmm, for many of these I didn't bother since acpidump -t already outputs these details so you can figure out what didn't match from the dump. It doesn't hurt to be more chatty though.