pmap: prefer memcpy over bcopy
ClosedPublic
Actions

Authored by brooks on Fri, Jun 19, 9:27 PM.

Details

Reviewers

emaste
jhb
imp
kib
andrew
manu

Group Reviewers

cheri

Commits

rG2ee2ef607f60: pmap: prefer memcpy over bcopy

Summary

Alter pmap_copy_page(s) to use memcpy rather than the deprecated bcopy.
We'll be adding non-provenance preserving versions for CHERI support and
wouod like to avoid introducing variants of deprecated APIs.

Suggested by: emaste
Sponsored by: Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74033
Build 70916: arc lint + arc unit

Event Timeline

brooks created this revision.Fri, Jun 19, 9:27 PM

Herald added a reviewer: andrew. · View Herald TranscriptFri, Jun 19, 9:27 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: riscv. · View Herald Transcript

brooks requested review of this revision.Fri, Jun 19, 9:27 PM

Herald added a reviewer: cheri. · View Herald TranscriptFri, Jun 19, 9:27 PM

Harbormaster completed remote builds in B74033: Diff 180109.Fri, Jun 19, 9:27 PM

brooks added a child revision: D57688: uiomove_*: centralize the copy function selection.Fri, Jun 19, 9:27 PM

amd64 is fine, but there are tons of bcopy use in amd64/amd64/*.c. Why is it fine for them to stay with bcopy? Or put it differently, why amd64 is affected at all?

This revision is now accepted and ready to land.Sat, Jun 20, 11:01 AM

In D57687#1322718, @kib wrote:

amd64 is fine, but there are tons of bcopy use in amd64/amd64/*.c. Why is it fine for them to stay with bcopy? Or put it differently, why amd64 is affected at all?

My aim was to eliminate bcopy in pmap_copy_page(s) in a consistent way. It seemed appropriate to replace the small number of remaining bcopies in the same file.