Differential D51553

vmm/amd64: VM_SET_CPUID ioctl should refuse zero-entry non-legacy cpuid cfg
Needs ReviewPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Jul 26 2025, 11:19 AM.

Tags

None

Referenced Files

	F172241615: D51553.diff
	Thu, Sep 17, 4:27 AM

	Unknown Object (File)
	Tue, Sep 15, 4:26 PM

	Unknown Object (File)
	Tue, Sep 15, 3:48 AM

	Unknown Object (File)
	Mon, Sep 14, 1:43 AM

	Unknown Object (File)
	Sun, Sep 13, 4:35 AM

	Unknown Object (File)
	Sat, Sep 12, 2:35 AM

	Unknown Object (File)
	Fri, Sep 11, 1:14 PM

	Unknown Object (File)
	Fri, Sep 11, 12:28 PM

View All 96 Files

Subscribers

Details

Reviewers

Group Reviewers

Summary

The kernel shouldn't accept a cpuid configuration that has no entries
without having the legacy flag set and just return EINVAL. A VCPU cpuid
configuration must either have zero cpuid entries and the legacy flag
set, or it must have the legacy flag clear and at least one cpuid entry.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72121
Build 69004: arc lint + arc unit

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Jul 26 2025, 11:19 AM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 26 2025, 11:19 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

rosenfeld_grumpf.hope-2000.org requested review of this revision.Jul 26 2025, 11:19 AM

Harbormaster completed remote builds in B65752: Diff 159180.Jul 26 2025, 11:19 AM

rosenfeld_grumpf.hope-2000.org added a parent revision: D51552: vmm/amd64: Port bhyve CPUID control from illumos.Jul 26 2025, 11:20 AM

rosenfeld_grumpf.hope-2000.org added a child revision: D51554: libvmmapi/amd64: Add support for CPUID ioctls to libvmmapi.Jul 26 2025, 11:22 AM

This should be merged into the previous commit D51552 shouldn't it?

In D51553#1178181, @corvink wrote:

This should be merged into the previous commit D51552 shouldn't it?

Yes, eventually it will be.

It's currently a separate change as it fixes an issue in the illumos code in D51552, and as such will be submitted to illumos separately eventually.

markj accepted this revision as: markj.Oct 21 2025, 3:21 PM

This revision is now accepted and ready to land.Oct 21 2025, 3:21 PM

Rebase.

This revision now requires review to proceed.Apr 10 2026, 6:38 PM

Harbormaster completed remote builds in B72121: Diff 175268.Apr 10 2026, 6:38 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

vmm_dev_machdep.c

8 lines

Diff 175268

sys/amd64/vmm/vmm_dev_machdep.c

Loading...