Page MenuHomeFreeBSD

asmc(4): pull 32-bit support for the driver
AcceptedPublic

Authored by ngie on Thu, Feb 26, 9:24 PM.
Tags
None
Referenced Files
F146037282: D55544.diff
Fri, Feb 27, 6:28 AM
F146017961: D55544.id172795.diff
Fri, Feb 27, 2:05 AM
F146016755: D55544.id.diff
Fri, Feb 27, 1:49 AM
F146012784: D55544.diff
Fri, Feb 27, 12:59 AM

Details

Reviewers
des
olce
Summary

The asmc(4) driver should work for 32-bit Intel-based Macs, in theory, if
the model details were added to the detection list. That being said,
32-bit Intel Macs were only released and available to the general public
for 8 months [1], so the value in maintaining i386 support is diminished
due to limited hardware access.

Remove 32-bit support for the driver officially to make it clear its use is
not supported.

This should fix building NOTES.i386 by proxy as well.

Relnotes: yes
MFC after: 2 weeks
Fixes: f224591746b ("Add ASMC_DEBUG make option")
Fixes: 8342d9f7b5f ("asmc(4): Stop building it on i386, as...")

Test Plan

I've been using this patch in one of my local git trees for quite a while and have run the change through make universe at least once.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71036
Build 67919: arc lint + arc unit

Event Timeline

ngie requested review of this revision.Thu, Feb 26, 9:24 PM
ngie added a reviewer: des.
ngie added subscribers: guest-seuros, markj, adrian.
ngie edited the summary of this revision. (Show Details)
sys/conf/files.amd64
114

This is unnecessary. Not sure why this is in this diff.

Remove superfluous line added to sys/conf/files.amd64 by accident

This revision is now accepted and ready to land.Fri, Feb 27, 9:45 AM