libsys, libc: provide rfork_thread() and pdrfork_thread() on all arches
posix_spawn: use rfork_thread on all arches
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
After this lands, RFSPAWN tests can be enabled on x86 by using *fork_thread() instead of raw *rfork().
| lib/libc/gen/posix_spawn.c | ||
|---|---|---|
| 354 | I do not follow, sorry. rfork_thread() is the public API, it takes explicit pointer to the stack. I implemented it for arches where it was missed. So the implementation is arch-specific but the interface is not. Are you proposing to add yet another function, now with the arch-specific interface? I would prefer not. | |
| lib/libc/gen/posix_spawn.c | ||
|---|---|---|
| 354 | Sorry, I wasn't thinking clearly. Really, I am wondering why not keep the first ifdef in this function, and just pass a NULL pointer for the stack on !x86. It seems a bit silly to do the allocation and argv traversal there. | |
| lib/libc/gen/posix_spawn.c | ||
|---|---|---|
| 354 | Hm, so you mean that the _gen implementation for !x86 is flawed, because it does not switch to the provided stack. I agree. But still, having it consistently provided on all arches is a right step IMO. | |
| lib/libc/gen/posix_spawn.c | ||
|---|---|---|
| 354 | Perhaps the generic implementation should return an error if a non-NULL stack is provided then? | |