Page MenuHomeFreeBSD
Differential D53421

vmm: Move the module load handler to vmm_dev.c
ClosedPublic
Actions

Authored by markj on Oct 28 2025, 8:30 PM.
Tags
None
Referenced Files
F171466807: D53421.id165818.diff
Fri, Sep 11, 6:49 AM
Unknown Object (File)
Mon, Sep 7, 9:30 AM
Unknown Object (File)
Tue, Sep 1, 4:18 PM
Unknown Object (File)
Fri, Aug 28, 12:12 PM
Unknown Object (File)
Fri, Aug 28, 10:14 AM
Unknown Object (File)
Wed, Aug 26, 10:07 AM
Unknown Object (File)
Tue, Aug 25, 1:38 AM
Unknown Object (File)
Mon, Aug 24, 7:02 PM
View All Files
Subscribers
bcran
corvink
emaste
imp
jhb
rgrimes
riscv

Details

Reviewers
andrew
manu
corvink
Group Reviewers
bhyve
Commits
rG16fe30d92da3: vmm: Move the module load handler to vmm_dev.c
rGe758074458df: vmm: Move the module load handler to vmm_dev.c
Summary

Move the vmm_initialized check out of vm_create() and into the legacy
sysctl handler. If vmm_initialized is false, /dev/vmmctl will not be
available and so cannot be used to create VMs.

Introduce new MD vmm_init() and vmm_cleanup() routines which handle MD
(de)initialization.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68287
Build 65170: arc lint + arc unit

Event Timeline

markj created this revision.Oct 28 2025, 8:30 PM
Herald added a reviewer: andrew. · View Herald TranscriptOct 28 2025, 8:30 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: riscv, bcran, rgrimes and 2 others. · View Herald Transcript
markj requested review of this revision.Oct 28 2025, 8:30 PM
Harbormaster completed remote builds in B68195: Diff 165258.Oct 28 2025, 8:30 PM
markj added a parent revision: D53420: amd64/vmm: Remove useless global variables.Oct 28 2025, 8:30 PM
markj added a child revision: D53422: vmm: Consolidate VM name length checking.
jhb added a subscriber: jhb.Oct 29 2025, 5:07 PM

In the commit message do you want to vmm_init -> vmm_modinit, etc.? Generally looks fine to me though.

sys/arm64/include/vmm.h
177 ↗(On Diff #165258)

Can these prototypes go in a single place (<dev/vmm/vmm_dev.h>?)?

corvink accepted this revision.Oct 30 2025, 7:45 AM
corvink added a subscriber: corvink.
corvink added inline comments.
sys/amd64/vmm/vmm.c
257

vmm_ipinum is already defined here.

This revision is now accepted and ready to land.Oct 30 2025, 7:45 AM
markj marked 2 inline comments as done.Oct 30 2025, 4:30 PM
In D53421#1220311, @jhb wrote:

In the commit message do you want to vmm_init -> vmm_modinit, etc.? Generally looks fine to me though.

Fixed, thanks.

markj updated this revision to Diff 165467.Oct 30 2025, 4:31 PM

Handle review feedback:

  • Move vmm_modinit()/modcleanup() prototypes to vmm_dev.h.
  • Remove a stray definition for vmm_ipinum.
This revision now requires review to proceed.Oct 30 2025, 4:31 PM
Harbormaster completed remote builds in B68287: Diff 165467.Oct 30 2025, 4:31 PM
corvink accepted this revision.Nov 3 2025, 7:15 AM
This revision is now accepted and ready to land.Nov 3 2025, 7:15 AM
Closed by commit rGe758074458df: vmm: Move the module load handler to vmm_dev.c (authored by markj). · Explain WhyNov 4 2025, 2:37 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGe758074458df: vmm: Move the module load handler to vmm_dev.c.
markj added a commit: rG16fe30d92da3: vmm: Move the module load handler to vmm_dev.c.Nov 18 2025, 3:03 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
83 lines
arm64/
vmm/
73 lines
dev/
vmm/
5 lines
65 lines
riscv/
vmm/
65 lines

Diff 165467

View Options

sys/amd64/vmm/vmm.c

Loading...
View Options

sys/arm64/vmm/vmm.c

Loading...
View Options

sys/dev/vmm/vmm_dev.h

Loading...
View Options

sys/dev/vmm/vmm_dev.c

Loading...
View Options

sys/riscv/vmm/vmm.c

Loading...