Differential D51656

jail: separate "statically valid allow flags" from "prison0 allow flags"
ClosedPublic
Actions

Authored by kevans on Thu, Jul 31, 5:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 12, 7:44 PM

	Unknown Object (File)
	Tue, Aug 12, 6:03 AM

	Unknown Object (File)
	Mon, Aug 11, 12:24 AM

	Unknown Object (File)
	Sat, Aug 9, 7:34 PM

	Unknown Object (File)
	Sat, Aug 9, 8:24 AM

	Unknown Object (File)
	Fri, Aug 8, 5:22 PM

	Unknown Object (File)
	Fri, Aug 8, 4:27 AM

	Unknown Object (File)
	Mon, Aug 4, 7:42 PM

View All 14 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rG58c92776d158: jail: separate "statically valid allow flags" from "prison0 allow flags"

Summary

The current setup means that we can't add an allow flag in sys/jail.h
that's disabled by default without removing it from the pr_flags
assignment in kern_jail.c. That's technically fine, but I think it's
better to make it more prevalent at the PR_ALLOW_* definition site so
that it's top-of-mind when adding a new flag.

This is a preparatory change for adding an allow flag that prison0 will
also have disabled by default, but with an allow.* knob and sysctl to
enable it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65866
Build 62749: arc lint + arc unit

Event Timeline

kevans created this revision.Thu, Jul 31, 5:22 PM

Herald added subscribers: olce, imp. · View Herald TranscriptThu, Jul 31, 5:22 PM

kevans requested review of this revision.Thu, Jul 31, 5:22 PM

Harbormaster completed remote builds in B65866: Diff 159502.Thu, Jul 31, 5:22 PM

kevans added a child revision: D51645: kern: disallow user scheduling/debugging/signalling of jailed procs.Thu, Jul 31, 5:44 PM

jamie accepted this revision as: Jails.Thu, Jul 31, 10:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Aug 8, 4:28 AM

Closed by commit rG58c92776d158: jail: separate "statically valid allow flags" from "prison0 allow flags" (authored by kevans). · Explain Why

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG58c92776d158: jail: separate "statically valid allow flags" from "prison0 allow flags".

Revision Contents
Changeset List

Path

Size

sys/

kern/

5 lines

sys/

8 lines

Diff 159502

sys/kern/kern_jail.c

Loading...

sys/sys/jail.h

Loading...