Differential D51268

d.7: Document the DTrace scripting language
ClosedPublic
Actions

Authored by 0mp on Fri, Jul 11, 8:45 PM.

Tags

Referenced Files

	F123909693: D51268.id158459.diff
	Sun, Jul 20, 8:39 AM

	F123909596: D51268.id158374.diff
	Sun, Jul 20, 8:38 AM

	F123908045: D51268.id158342.diff
	Sun, Jul 20, 8:12 AM

	F123907872: D51268.id158370.diff
	Sun, Jul 20, 8:09 AM

	F123907830: D51268.id158351.diff
	Sun, Jul 20, 8:09 AM

	F123907778: D51268.id158425.diff
	Sun, Jul 20, 8:08 AM

	F123906857: D51268.id158462.diff
	Sun, Jul 20, 7:53 AM

	Unknown Object (File)
	Fri, Jul 18, 2:32 AM

View All 13 Files

Subscribers

Details

Reviewers

bnovkov
christos
markj
gnn

Commits

rG193f2289fc9a: d.7: Document the DTrace scripting language

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65381
Build 62264: arc lint + arc unit

Event Timeline

0mp created this revision.Fri, Jul 11, 8:45 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Jul 11, 8:45 PM

0mp requested review of this revision.Fri, Jul 11, 8:45 PM

Harbormaster completed remote builds in B65365: Diff 158342.Fri, Jul 11, 8:45 PM

0mp edited the summary of this revision. (Show Details)Fri, Jul 11, 8:45 PM

0mp added a project: DTrace.

ziaee added inline comments.Fri, Jul 11, 8:57 PM

share/man/man7/d.7
12	Maybe?

Improve Nd

Harbormaster completed remote builds in B65370: Diff 158351.Sat, Jul 12, 7:28 AM

0mp added inline comments.Sat, Jul 12, 7:28 AM

share/man/man7/d.7
12	Why not! Thank you :)

A few minor things, the rest looks fine.

share/man/man7/d.7
77	I don't think you need a comma here.
80	same here
155	s/handling a/handling of a/

Finish the first draft.

Harbormaster completed remote builds in B65371: Diff 158358.Sat, Jul 12, 9:22 AM

0mp edited the summary of this revision. (Show Details)Sat, Jul 12, 1:51 PM

0mp added reviewers: bnovkov, christos, markj.

0mp added a project: docs.

Address bcr's feedback
Reference ddb(4) as the kernel debugger, not kgdb

Harbormaster completed remote builds in B65378: Diff 158370.Sat, Jul 12, 2:18 PM

Move cwd to BUGS and mention that it is not supported at the moment.

Harbormaster completed remote builds in B65381: Diff 158374.Sat, Jul 12, 3:09 PM

Document execargs
Add a note what execname is.

Harbormaster completed remote builds in B65382: Diff 158379.Sat, Jul 12, 3:46 PM

christos added inline comments.Sun, Jul 13, 2:40 PM

share/man/man7/d.7
79	Isn't this sentence redundant, since the previous sentence already says that an enabled probed is defined by its probe ID?
96	Better to make this the second one in order to match the order of the probe description fields (provider, module, function, name).
148
197	I think here and below it's better to get rid of the "a/an".

Add bcr's comments

Harbormaster completed remote builds in B65403: Diff 158425.Sun, Jul 13, 4:12 PM

Address feedback

Harbormaster completed remote builds in B65411: Diff 158459.Mon, Jul 14, 12:11 PM

@ziaee, could you check the apropos(1) compliance? ;)

share/man/man7/d.7
79	So this comment is about: The enabled probe ID which uniquely identifies an enabled probe. An enabled probe is defined by its probe ID, its predicates, and its actions. I think it is necessary, because those 3 items are what makes the enabled probe unique. It is not redundant.

christos added inline comments.Mon, Jul 14, 12:16 PM

share/man/man7/d.7
203	The first letter should be capitalized, no?

Capitalize descriptions of aggregation functions

Harbormaster completed remote builds in B65412: Diff 158462.Mon, Jul 14, 12:21 PM

0mp marked an inline comment as done.Mon, Jul 14, 12:21 PM

0mp added inline comments.

share/man/man7/d.7
203	Sure, why not.

0mp marked an inline comment as done.Mon, Jul 14, 12:22 PM

christos accepted this revision.Mon, Jul 14, 12:26 PM

This revision is now accepted and ready to land.Mon, Jul 14, 12:26 PM

Thanks!

Closed by commit rG193f2289fc9a: d.7: Document the DTrace scripting language (authored by 0mp). · Explain WhyMon, Jul 14, 1:02 PM

This revision was automatically updated to reflect the committed changes.

0mp added a commit: rG193f2289fc9a: d.7: Document the DTrace scripting language.

Herald added a reviewer: gnn. · View Herald TranscriptMon, Jul 14, 1:02 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man7/

1 line

274 lines

Diff 158374

share/man/man7/Makefile

Loading...

share/man/man7/d.7

Loading...