Page MenuHomeFreeBSD
Differential D51268

d.7: Document the DTrace scripting language
ClosedPublic
Actions

Authored by 0mp on Jul 11 2025, 8:45 PM.
Tags
Referenced Files
F133210336: D51268.id158351.diff
Fri, Oct 24, 12:16 AM
Unknown Object (File)
Thu, Oct 23, 4:47 AM
Unknown Object (File)
Tue, Oct 21, 3:38 PM
Unknown Object (File)
Tue, Oct 21, 8:32 AM
Unknown Object (File)
Tue, Oct 21, 2:40 AM
Unknown Object (File)
Sun, Oct 19, 5:48 PM
Unknown Object (File)
Sat, Oct 18, 1:58 PM
Unknown Object (File)
Sat, Oct 18, 11:59 AM
View All 80 Files
Subscribers
bcr
imp
ziaee

Details

Reviewers
bnovkov
christos
markj
gnn
Commits
rG193f2289fc9a: d.7: Document the DTrace scripting language

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65412
Build 62295: arc lint + arc unit

Event Timeline

0mp created this revision.Jul 11 2025, 8:45 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptJul 11 2025, 8:45 PM
0mp requested review of this revision.Jul 11 2025, 8:45 PM
Harbormaster completed remote builds in B65365: Diff 158342.Jul 11 2025, 8:45 PM
0mp edited the summary of this revision. (Show Details)Jul 11 2025, 8:45 PM
0mp added a project: DTrace.
ziaee added inline comments.Jul 11 2025, 8:57 PM
share/man/man7/d.7
12

Maybe?

0mp updated this revision to Diff 158351.Jul 12 2025, 7:28 AM
0mp marked an inline comment as done.
  • Improve Nd
Harbormaster completed remote builds in B65370: Diff 158351.Jul 12 2025, 7:28 AM
0mp added inline comments.Jul 12 2025, 7:28 AM
share/man/man7/d.7
12

Why not! Thank you :)

bcr added a subscriber: bcr.Jul 12 2025, 8:59 AM

A few minor things, the rest looks fine.

share/man/man7/d.7
77

I don't think you need a comma here.

80

same here

155

s/handling a/handling of a/

0mp updated this revision to Diff 158358.Jul 12 2025, 9:22 AM

Finish the first draft.

Harbormaster completed remote builds in B65371: Diff 158358.Jul 12 2025, 9:22 AM
0mp edited the summary of this revision. (Show Details)Jul 12 2025, 1:51 PM
0mp added reviewers: bnovkov, christos, markj.
0mp added a project: docs.
0mp updated this revision to Diff 158370.Jul 12 2025, 2:18 PM
0mp marked 2 inline comments as done.
  • Address bcr's feedback
  • Reference ddb(4) as the kernel debugger, not kgdb
Harbormaster completed remote builds in B65378: Diff 158370.Jul 12 2025, 2:18 PM
0mp updated this revision to Diff 158374.Jul 12 2025, 3:09 PM
  • Move cwd to BUGS and mention that it is not supported at the moment.
Harbormaster completed remote builds in B65381: Diff 158374.Jul 12 2025, 3:09 PM
0mp updated this revision to Diff 158379.Jul 12 2025, 3:46 PM
  • Document execargs
  • Add a note what execname is.
Harbormaster completed remote builds in B65382: Diff 158379.Jul 12 2025, 3:46 PM
christos added inline comments.Jul 13 2025, 2:40 PM
share/man/man7/d.7
79

Isn't this sentence redundant, since the previous sentence already says that an enabled probed is defined by its probe ID?

96

Better to make this the second one in order to match the order of the probe description fields (provider, module, function, name).

148
197

I think here and below it's better to get rid of the "a/an".

0mp updated this revision to Diff 158425.Jul 13 2025, 4:12 PM
  • Add bcr's comments
Harbormaster completed remote builds in B65403: Diff 158425.Jul 13 2025, 4:12 PM
0mp updated this revision to Diff 158459.Jul 14 2025, 12:11 PM
0mp marked 5 inline comments as done.
  • Address feedback
Harbormaster completed remote builds in B65411: Diff 158459.Jul 14 2025, 12:11 PM
0mp added a comment.Jul 14 2025, 12:11 PM

@ziaee, could you check the apropos(1) compliance? ;)

share/man/man7/d.7
79

So this comment is about:

The enabled probe ID which uniquely identifies an enabled probe.
An enabled probe is defined by its probe ID, its predicates, and its actions.

I think it is necessary, because those 3 items are what makes the enabled probe unique. It is not redundant.

christos added inline comments.Jul 14 2025, 12:16 PM
share/man/man7/d.7
203

The first letter should be capitalized, no?

0mp updated this revision to Diff 158462.Jul 14 2025, 12:21 PM
  • Capitalize descriptions of aggregation functions
Harbormaster completed remote builds in B65412: Diff 158462.Jul 14 2025, 12:21 PM
0mp marked an inline comment as done.Jul 14 2025, 12:21 PM
0mp added inline comments.
share/man/man7/d.7
203

Sure, why not.

0mp marked an inline comment as done.Jul 14 2025, 12:22 PM
christos accepted this revision.Jul 14 2025, 12:26 PM
This revision is now accepted and ready to land.Jul 14 2025, 12:26 PM
0mp added a comment.Jul 14 2025, 1:02 PM

Thanks!

Closed by commit rG193f2289fc9a: d.7: Document the DTrace scripting language (authored by 0mp). · Explain WhyJul 14 2025, 1:02 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rG193f2289fc9a: d.7: Document the DTrace scripting language.
Herald added a reviewer: gnn. · View Herald TranscriptJul 14 2025, 1:02 PM

Revision Contents
Changeset List

PathSize
share/
man/
man7/
1 line
287 lines

Diff 158462

View Options

share/man/man7/Makefile

Loading...
View Options

share/man/man7/d.7

Loading...