Page MenuHomeFreeBSD

rtwn: remove SEQ_SEL, replace with a QOS bit
ClosedPublic

Authored by adrian on Dec 15 2024, 6:20 PM.
Referenced Files
F122442446: D48092.id148587.diff
Sat, Jul 5, 9:22 AM
F122440324: D48092.id147987.diff
Sat, Jul 5, 9:00 AM
F122436428: D48092.id.diff
Sat, Jul 5, 8:21 AM
Unknown Object (File)
Wed, Jul 2, 2:37 AM
Unknown Object (File)
Tue, Jul 1, 10:45 AM
Unknown Object (File)
Tue, Jul 1, 8:50 AM
Unknown Object (File)
Tue, Jun 24, 11:37 PM
Unknown Object (File)
Mon, Jun 23, 3:06 AM
Subscribers

Details

Summary

I've reviewed all of the linux vendor and upstream drivers.
This SEQ_SEL field isn't a mask and doesn't ever look like it
it was; instead this bit is set to tag QoS data frames.

In fact, it effectively was set to 0 for STA frames and potentially 1
for broadcast/multicast frames as the STA macid of 0 and broadcast/
multicast macid of 1 maps to that. In AP modes it would be tagged
based on bit 0.

So, bring it in line with the vendor and linux drivers.

Locally tested:

  • RTL8192CU, STA, hostap
  • RTL8188EU, STA
  • RTL8192EU, STA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable