Page MenuHomeFreeBSD
Differential D47776

rtwn: enable receiving AMSDU in AMPDU
ClosedPublic
Actions

Authored by adrian on Nov 27 2024, 4:40 AM.
Tags
Referenced Files
F111344984: D47776.id147024.diff
Sun, Mar 2, 3:49 PM
Unknown Object (File)
Fri, Feb 28, 4:19 PM
Unknown Object (File)
Wed, Feb 19, 3:56 PM
Unknown Object (File)
Jan 25 2025, 9:44 AM
Unknown Object (File)
Jan 25 2025, 9:37 AM
Unknown Object (File)
Jan 24 2025, 12:30 PM
Unknown Object (File)
Jan 22 2025, 3:19 AM
Unknown Object (File)
Jan 21 2025, 1:08 AM
View All 24 Files
Subscribers
bz
imp

Details

Reviewers
None
Group Reviewers
wireless
Commits
rG05c3851b20e0: rtwn: enable receiving AMSDU in AMPDU
Summary

All of the supported NICs should support this.

Locally tested:

  • RTL8192CU, STA mode
  • RTL8192EU, STA mode
  • RTL8821AU, STA mode
  • RTL8812AU, STA mode

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60805
Build 57689: arc lint + arc unit

Event Timeline

adrian created this revision.Nov 27 2024, 4:40 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 27 2024, 4:40 AM
adrian requested review of this revision.Nov 27 2024, 4:40 AM
Harbormaster completed remote builds in B60805: Diff 147023.Nov 27 2024, 4:40 AM
adrian updated this revision to Diff 147024.Nov 27 2024, 4:40 AM

url

Harbormaster completed remote builds in B60806: Diff 147024.Nov 27 2024, 4:40 AM
adrian added a parent revision: D47775: rtwn: enable FCS in the recive config to work around truncated frames.Nov 27 2024, 4:41 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
bz added a subscriber: bz.Nov 28 2024, 1:15 AM

Likely fine but should make sure that all the different devices/firmware really can do that.

adrian added a comment.Dec 1 2024, 7:20 PM
In D47776#1090169, @bz wrote:

Likely fine but should make sure that all the different devices/firmware really can do that.

I've checked; RTL8188 and RTL8192 NICs support it fine. There's some other instabilities, but not linked to this!

adrian added a child revision: D47860: rtwn: remove the conditional compilation around the sc_ht40 option..Dec 2 2024, 5:32 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 5 2024, 7:31 AM
Closed by commit rG05c3851b20e0: rtwn: enable receiving AMSDU in AMPDU (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG05c3851b20e0: rtwn: enable receiving AMSDU in AMPDU.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
1 line

Diff 147023

View Options

sys/dev/rtwn/if_rtwn.c

Loading...