Differential D47541

tcp: fix cwnd recalculation during limited transmit
ClosedPublic
Actions

Authored by rscheff on Wed, Nov 13, 6:58 PM.

Tags

None

Referenced Files

	F103172906: D47541.id146453.diff
	Thu, Nov 21, 9:18 PM

	F103155492: D47541.diff
	Thu, Nov 21, 4:50 PM

	Unknown Object (File)
	Wed, Nov 20, 10:49 PM

	Unknown Object (File)
	Mon, Nov 18, 8:32 AM

	Unknown Object (File)
	Sat, Nov 16, 11:53 PM

	Unknown Object (File)
	Sat, Nov 16, 12:20 PM

	Unknown Object (File)
	Thu, Nov 14, 6:38 PM

	Unknown Object (File)
	Thu, Nov 14, 8:01 AM

Subscribers

Details

Reviewers

tuexen
cc
glebius

Group Reviewers

Commits

rG8f5a2e216f4c: tcp: fix cwnd recalculation during limited transmit

Summary

During limited transmit, one additional segment should be
sent for each incoming ACK. As tcp_output considers the
SACKed bytes, adjust for this in the limited transmit
recalculation.
Also, in case snd_nxt is lower than snd_max (after an RTO),
let tcp_output only consider retransmissions from the SACK
scoreboard when again in fast recovery mode, or dupthresh
dupacks have been seen.

PR: 282605

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 60521
Build 57405: arc lint + arc unit

Event Timeline

rscheff created this revision.Wed, Nov 13, 6:58 PM

Herald added a reviewer: transport. · View Herald TranscriptWed, Nov 13, 6:58 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Wed, Nov 13, 6:58 PM

Harbormaster completed remote builds in B60521: Diff 146365.Wed, Nov 13, 6:58 PM

tuexen accepted this revision.Thu, Nov 14, 3:24 PM

This revision is now accepted and ready to land.Thu, Nov 14, 3:24 PM

Closed by commit rG8f5a2e216f4c: tcp: fix cwnd recalculation during limited transmit (authored by rscheff). · Explain WhyThu, Nov 14, 6:00 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG8f5a2e216f4c: tcp: fix cwnd recalculation during limited transmit.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

2 lines

3 lines

Diff 146365

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_output.c

Loading...