Differential D46588

pf: add a new log opt PF_LOG_MATCHES
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 19, 6:22 PM

	Unknown Object (File)
	Sun, Jul 12, 8:33 PM

	Unknown Object (File)
	Mon, Jun 29, 11:02 AM

	Unknown Object (File)
	Mon, Jun 22, 11:44 PM

	Unknown Object (File)
	Mon, Jun 22, 10:50 PM

	Unknown Object (File)
	Jun 12 2026, 9:39 PM

	Unknown Object (File)
	May 30 2026, 12:12 PM

	Unknown Object (File)
	May 29 2026, 3:16 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rGf3ab00c2b607: pf: add a new log opt PF_LOG_MATCHES

Summary

forces logging on all subsequent matching rules
new log opt "matches"
awesome for debugging, a rule like
match log(matches) from $testbox
will show you exactly which subsequent rules match on that packet
real ok theo assumed oks ryan & dlg bikeshedding many

Obtained from: OpenBSD, henning <henning@openbsd.org>, 1603e01ae4
Obtained from: OpenBSD, henning <henning@openbsd.org>, f496e91672
Obtained from: OpenBSD, henning <henning@openbsd.org>, 07481a9fee
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 7 2024, 9:35 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 7 2024, 9:35 AM

kp requested review of this revision.Sep 7 2024, 9:35 AM

Harbormaster completed remote builds in B59376: Diff 143084.Sep 7 2024, 9:35 AM

kp added a parent revision: D46587: pf: drop packets if pullup fails.Sep 7 2024, 9:35 AM

kp added a child revision: D46589: pf tests: test the new log(matches) feature.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2024, 8:22 PM

Closed by commit rGf3ab00c2b607: pf: add a new log opt PF_LOG_MATCHES (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGf3ab00c2b607: pf: add a new log opt PF_LOG_MATCHES.

Revision Contents
Changeset List

Path

Size

sbin/

pfctl/

4 lines

2 lines

share/

man/

man5/

4 lines

sys/

netpfil/

pf/

1 line

8 lines

Diff 143484

sbin/pfctl/parse.y

Loading...

sbin/pfctl/pfctl_parser.c

Loading...

share/man/man5/pf.conf.5

Loading...

sys/netpfil/pf/pf.h

Loading...

sys/netpfil/pf/pf.c

Loading...