pf: always drop ICMPv6 in IPv4 datagrams
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:33 AM.

Tags

None

Referenced Files

	F168299990: D46575.id.diff
	Thu, Aug 27, 12:30 PM

	F168213395: D46575.id143071.diff
	Wed, Aug 26, 10:44 PM

	Unknown Object (File)
	Wed, Aug 26, 11:03 AM

	Unknown Object (File)
	Tue, Aug 25, 7:54 PM

	Unknown Object (File)
	Tue, Aug 25, 12:54 PM

	Unknown Object (File)
	Thu, Aug 20, 10:29 AM

	Unknown Object (File)
	Thu, Aug 13, 12:39 AM

	Unknown Object (File)
	Mon, Aug 10, 1:08 PM

Subscribers

vegeta_tuxpowered.net

zlei

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rG2ca286d0d260: pf: always drop ICMPv6 in IPv4 datagrams

Summary

Not only when compiled with INET6.

Suggested by Max Laier.
ok henning@

Obtained from: OpenBSD, jsing <jsing@openbsd.org>, 0ba1e6e32b9
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 7 2024, 9:33 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 7 2024, 9:33 AM

kp requested review of this revision.Sep 7 2024, 9:33 AM

kp added a parent revision: D46574: pf: fix debug printf.

Harbormaster completed remote builds in B59363: Diff 143071.Sep 7 2024, 9:33 AM

kp added a child revision: D46576: pf: use AF_INET6 when comparing IPv6 addresses.Sep 7 2024, 9:33 AM

Reasonable!

This revision is now accepted and ready to land.Sep 14 2024, 7:23 AM

Closed by commit rG2ca286d0d260: pf: always drop ICMPv6 in IPv4 datagrams (authored by kp). · Explain WhySep 16 2024, 1:05 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG2ca286d0d260: pf: always drop ICMPv6 in IPv4 datagrams.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

2 lines

Diff 143383

View Options

pf: always drop ICMPv6 in IPv4 datagramsClosedPublicActions