Page MenuHomeFreeBSD
Differential D46314

rangeset: speed up range traveral
ClosedPublic
Actions

Authored by dougm on Aug 17 2024, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 4:10 AM
Unknown Object (File)
Sun, Mar 30, 10:57 PM
Unknown Object (File)
Feb 11 2025, 12:46 AM
Unknown Object (File)
Jan 27 2025, 5:07 PM
Unknown Object (File)
Jan 26 2025, 6:19 PM
Unknown Object (File)
Jan 24 2025, 7:31 PM
Unknown Object (File)
Jan 22 2025, 3:44 AM
Unknown Object (File)
Jan 17 2025, 9:52 PM
View All 36 Files
Subscribers
emaste
imp
olce
pho

Details

Reviewers
andrew
manu
kib
Commits
rG8aa2cd9d13d4: rangeset: speed up range traversal
Summary

For rangeset-next search, use exact search rather than greater-than search.

Move a bit of the testing logic from the pmap code to the rangeset code.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Aug 17 2024, 6:26 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 17 2024, 6:26 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a subscriber: emaste. · View Herald Transcript
dougm requested review of this revision.Aug 17 2024, 6:26 PM
dougm mentioned this in D45627: pctrie: create iterator.Aug 17 2024, 6:38 PM
pho added a subscriber: pho.Aug 17 2024, 6:51 PM
kib accepted this revision.Aug 19 2024, 8:06 AM
This revision is now accepted and ready to land.Aug 19 2024, 8:06 AM
dougm updated this revision to Diff 143134.Sep 9 2024, 7:37 AM
dougm retitled this revision from rangeset: use pctrie iterators for range traversal to rangeset: speed up range traveral.
dougm edited the summary of this revision. (Show Details)

Strip the iterators out, since there's no sign they'll be reviewed soon. There's still a bit left worth committing.

This revision now requires review to proceed.Sep 9 2024, 7:37 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2024, 9:52 PM
Closed by commit rG8aa2cd9d13d4: rangeset: speed up range traversal (authored by dougm). · Explain Why
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rG8aa2cd9d13d4: rangeset: speed up range traversal.
Herald added subscribers: olce, imp. · View Herald TranscriptSep 9 2024, 9:52 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
20 lines
arm64/
arm64/
19 lines
kern/
23 lines
sys/
14 lines

Diff 143134

View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/arm64/arm64/pmap.c

Loading...
View Options

sys/kern/subr_rangeset.c

Loading...
View Options

sys/sys/rangeset.h

Loading...