sound examples: Simplify MIDI example
ClosedPublic
Actions

Authored by christos on Aug 15 2024, 3:04 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch
meka_tilda.center

Commits

rG276d76adf984: sound examples: Simplify MIDI example
rG0ca4d5d8209c: sound examples: Simplify MIDI example

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59034
Build 55921: arc lint + arc unit

Event Timeline

christos created this revision.Aug 15 2024, 3:04 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2024, 3:04 PM

christos requested review of this revision.Aug 15 2024, 3:04 PM

Harbormaster completed remote builds in B59031: Diff 142112.Aug 15 2024, 3:04 PM

christos added a child revision: D46307: sound examples: Simplify audio example.Aug 15 2024, 3:04 PM

Commit message should include some more detail (e.g. explain that it's not really OSS) and will need an ObsoleteFiles.inc update for the now-removed ossmidi.h.

In D46306#1056039, @emaste wrote:

Commit message should include some more detail (e.g. explain that it's not really OSS) and will need an ObsoleteFiles.inc update for the now-removed ossmidi.h.

I will combine D46308 with this and update ObsoleteFiles.inc. Updating the diff in a few mins.

It might be better to keep the move & rewrite as separate commits so it's clear to git that it's the same file (rather than inferring this from delete + new file that are similar); if you do keep them separate I don't have a strong opinion on move-then-edit or edit-then-move.

In D46306#1056044, @emaste wrote:

It might be better to keep the move & rewrite as separate commits so it's clear to git that it's the same file (rather than inferring this from delete + new file that are similar); if you do keep them separate I don't have a strong opinion on move-then-edit or edit-then-move.

Alright. Regarding the commit message I mention that this code is not OSS related in the other patch, which is the one that actually moves it out of oss/.

Add ossmidi.h remove to ObsoleteFiles.inc.

Harbormaster completed remote builds in B59034: Diff 142115.Aug 15 2024, 4:02 PM

emaste accepted this revision.Aug 17 2024, 4:24 PM

This revision is now accepted and ready to land.Aug 17 2024, 4:24 PM

dev_submerge.ch added inline comments.Aug 20 2024, 2:55 PM