Page MenuHomeFreeBSD

sound examples: Simplify audio example
ClosedPublic

Authored by christos on Aug 15 2024, 3:04 PM.
Tags
None
Referenced Files
F100506548: D46307.id142402.diff
Wed, Oct 16, 2:52 AM
F100398942: D46307.id142402.diff
Tue, Oct 15, 3:07 PM
Unknown Object (File)
Tue, Oct 15, 6:19 AM
Unknown Object (File)
Mon, Oct 14, 12:30 PM
Unknown Object (File)
Sun, Oct 13, 9:01 AM
Unknown Object (File)
Sat, Oct 12, 4:21 AM
Unknown Object (File)
Fri, Oct 11, 6:47 PM
Unknown Object (File)
Thu, Oct 10, 9:20 PM
Subscribers

Details

Summary
  • Merge ossinit.h and basic.c.
  • Rename basic.c to audio.c.
  • Use err(3) instead of fprintf(3) + exit(3).
  • Some style(9) improvements.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Add ossinit.h removal to ObsoleteFiles.inc.

Add basic.c rename to ObsoleteFiles.inc as well.

I suppose the original idea by @meka_tilda.center was to implement another example using mmap, at least there's code fragments for that. What's the plan regarding a mmap example?

I suppose the original idea by @meka_tilda.center was to implement another example using mmap, at least there's code fragments for that. What's the plan regarding a mmap example?

Here I simply re-arranged and cleaned up some parts. I think the mmap example should be added in a separate patch.

This revision is now accepted and ready to land.Aug 20 2024, 3:31 PM

I suppose the original idea by @meka_tilda.center was to implement another example using mmap, at least there's code fragments for that. What's the plan regarding a mmap example?

To be honest, at the time of writing those examples I didn't know much about FreeBSD audio. As a matter of fact, that was the reason I wrote them: I wanted to learn and write it down for others. So, thank you, Christos, for improving it. Where I hit the wall is mmap mode and kqueue example, because cuse (hence, virtual_oss) has kqueue handler, but kernel OSS doesn't. What I'm trying to say is that I wrote down in those examples as I learned, so no wonder there are traces of mmap support.

This revision was automatically updated to reflect the committed changes.