Page MenuHomeFreeBSD
Differential D45511

rangeset: add next() for iteration
ClosedPublic
Actions

Authored by dougm on Jun 6 2024, 9:02 AM.
Tags
None
Referenced Files
F150879881: D45511.id.diff
Sat, Apr 4, 4:32 PM
F150819053: D45511.id139553.diff
Sat, Apr 4, 6:41 AM
F150811848: D45511.id139550.diff
Sat, Apr 4, 5:28 AM
Unknown Object (File)
Fri, Apr 3, 3:07 PM
Unknown Object (File)
Fri, Apr 3, 10:31 AM
Unknown Object (File)
Thu, Apr 2, 7:12 PM
Unknown Object (File)
Thu, Apr 2, 4:59 PM
Unknown Object (File)
Mon, Mar 23, 9:44 AM
View All Files
Subscribers
emaste
imp
olce

Details

Reviewers
alc
kib
andrew
manu
Commits
rG2c10bacdf402: rangeset: add next() iteration
Summary

Add a method rangeset_next to find the first range that starts at or after a given value. Use it to rewrite pmap_pkru_same to avoid walking a page at a time over pages in no range.

Test Plan

A kernel builds and boots.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Jun 6 2024, 9:02 AM
dougm created this revision.
dougm updated this revision to Diff 139550.Jun 6 2024, 9:32 AM

Make similar changes for arm64.

Herald added a reviewer: andrew. · View Herald TranscriptJun 6 2024, 9:32 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a subscriber: emaste. · View Herald Transcript
andrew added inline comments.Jun 6 2024, 10:06 AM
sys/arm64/arm64/pmap.c
9296

Shouldn't we use va here?

dougm updated this revision to Diff 139552.Jun 6 2024, 10:14 AM
dougm marked an inline comment as done.

Fix lazy editting observed by @andrew

sys/arm64/arm64/pmap.c
9296

Yep.

dougm updated this revision to Diff 139553.Jun 6 2024, 10:18 AM

Typos abound. Squashed another.

kib accepted this revision.Jun 6 2024, 2:32 PM
This revision is now accepted and ready to land.Jun 6 2024, 2:32 PM
andrew accepted this revision.Jun 6 2024, 5:50 PM
Closed by commit rG2c10bacdf402: rangeset: add next() iteration (authored by dougm). · Explain WhyJun 6 2024, 6:45 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rG2c10bacdf402: rangeset: add next() iteration.
Herald added subscribers: olce, imp. · View Herald TranscriptJun 6 2024, 6:45 PM
alc added a comment.Jun 6 2024, 7:01 PM

@kib Do you have any PKU test programs that could be run to check this?

kib added a comment.Jun 6 2024, 8:46 PM
In D45511#1038472, @alc wrote:

@kib Do you have any PKU test programs that could be run to check this?

Specifically to check this patch, probably not. Existing PKRU tests were imported as tools/test/stress2/misc/pkru.sh and pkru2.sh.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
26 lines
arm64/
arm64/
23 lines
kern/
8 lines
sys/
5 lines

Diff 139553

View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/arm64/arm64/pmap.c

Loading...
View Options

sys/kern/subr_rangeset.c

Loading...
View Options

sys/sys/rangeset.h

Loading...