Page MenuHomeFreeBSD
Differential D41752

libvmmapi: Make vm_raise_msi() a common function
ClosedPublic
Actions

Authored by markj on Sep 6 2023, 12:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 25, 9:42 AM
Unknown Object (File)
Feb 18 2025, 7:54 AM
Unknown Object (File)
Feb 15 2025, 7:37 PM
Unknown Object (File)
Feb 9 2025, 6:17 PM
Unknown Object (File)
Jan 28 2025, 2:10 AM
Unknown Object (File)
Jan 25 2025, 1:59 AM
Unknown Object (File)
Jan 25 2025, 1:47 AM
Unknown Object (File)
Jan 24 2025, 11:44 PM
View All 85 Files
Subscribers
emaste
imp
rgrimes

Details

Reviewers
jhb
corvink
andrew
Group Reviewers
bhyve
Commits
rG1855002ddf0b: libvmmapi: Make vm_raise_msi() a common function
Summary

Currently, bhyve PCI emulation uses vm_lapic_msi() to raise an MSI in
the guest. The arm64 port has a similar function, vm_raise_msi().
Add vm_raise_msi() on amd64 as well and have it simply call
vm_lapic_msi() so that bhyve can use a common, generically named
function.

For some reason the arm64 VM_RAISE_MSI ioctl takes a PCI device
identifier, but it is unused. Simply remove those parameters from the
arm64 prototype for now.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Sep 6 2023, 12:29 AM
Herald added a reviewer: bhyve. · View Herald TranscriptSep 6 2023, 12:29 AM
Herald added subscribers: rgrimes, emaste, imp. · View Herald Transcript
markj requested review of this revision.Sep 6 2023, 12:29 AM
Harbormaster completed remote builds in B53455: Diff 126925.Sep 6 2023, 12:30 AM
markj added a parent revision: D41005: libvmmapi: Add arm64 support.Sep 6 2023, 12:31 AM
markj mentioned this in D41740: bhyve: Use vm_raise_msi() instead of vm_lapic_msi().
corvink accepted this revision.Sep 6 2023, 9:31 AM
corvink added inline comments.
lib/libvmmapi/vmmapi.h
170

Nit: This doesn't belong to your change.

This revision is now accepted and ready to land.Sep 6 2023, 9:31 AM
andrew added inline comments.Sep 6 2023, 9:41 AM
lib/libvmmapi/aarch64/vmmapi_machdep.c
112

If we implement the GICv3 ITS we will likely need some of these fields.

markj updated this revision to Diff 126957.Sep 6 2023, 2:15 PM

Restore PCI b/s/f tuple parameters.

This revision now requires review to proceed.Sep 6 2023, 2:15 PM
Harbormaster completed remote builds in B53465: Diff 126957.Sep 6 2023, 2:15 PM
jhb accepted this revision.Sep 6 2023, 3:14 PM

Don't forget to drop the last paragraph from the commit log.

This revision is now accepted and ready to land.Sep 6 2023, 3:14 PM
andrew accepted this revision.Sep 6 2023, 4:05 PM
corvink accepted this revision.Sep 7 2023, 8:42 AM
Closed by commit rG1855002ddf0b: libvmmapi: Make vm_raise_msi() a common function (authored by markj). · Explain WhyApr 10 2024, 3:20 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG1855002ddf0b: libvmmapi: Make vm_raise_msi() a common function.

Revision Contents
Changeset List

PathSize
lib/
libvmmapi/
aarch64/
4 lines
amd64/
7 lines
6 lines

Diff 136857

View Options

lib/libvmmapi/aarch64/vmmapi_machdep.c

Context not available.
struct in6_addr clat_prefix; /* Client (CLAT) prefix */ struct in6_addr clat_prefix; /* Client (CLAT) prefix */
uint8_t plat_plen; /* PLAT Prefix length */ uint8_t plat_plen; /* PLAT Prefix length */
uint8_t clat_plen; /* CLAT Prefix length */ uint8_t clat_plen; /* CLAT Prefix length */
uint8_t clat_local; /* CLAT UE parameter */
donnerUnsubmitted
Not Done
Inline Actions

Adding a new value into the struct causes an ABI break.
Adding a new flag to the existing flags variable (below), maintains backward compatibility.

donner: Adding a new value into the struct causes an ABI break. Adding a new flag to the existing flags…
uint8_t set; /* Named instance set [0..31] */ uint8_t set; /* Named instance set [0..31] */
uint8_t spare; uint8_t spare;
uint32_t flags; uint32_t flags;
Context not available.
View Options

lib/libvmmapi/amd64/vmmapi_machdep.c

Context not available.
struct in6_addr clat_prefix; /* Client (CLAT) prefix */ struct in6_addr clat_prefix; /* Client (CLAT) prefix */
uint8_t plat_plen; /* PLAT Prefix length */ uint8_t plat_plen; /* PLAT Prefix length */
uint8_t clat_plen; /* CLAT Prefix length */ uint8_t clat_plen; /* CLAT Prefix length */
uint8_t clat_local; /* CLAT UE parameter */
donnerUnsubmitted
Not Done
Inline Actions

Adding a new value into the struct causes an ABI break.
Adding a new flag to the existing flags variable (below), maintains backward compatibility.

donner: Adding a new value into the struct causes an ABI break. Adding a new flag to the existing flags…
uint8_t set; /* Named instance set [0..31] */ uint8_t set; /* Named instance set [0..31] */
uint8_t spare; uint8_t spare;
uint32_t flags; uint32_t flags;
Context not available.
View Options

lib/libvmmapi/vmmapi.h

Context not available.
struct in6_addr clat_prefix; /* Client (CLAT) prefix */ struct in6_addr clat_prefix; /* Client (CLAT) prefix */
uint8_t plat_plen; /* PLAT Prefix length */ uint8_t plat_plen; /* PLAT Prefix length */
uint8_t clat_plen; /* CLAT Prefix length */ uint8_t clat_plen; /* CLAT Prefix length */
uint8_t clat_local; /* CLAT UE parameter */
donnerUnsubmitted
Not Done
Inline Actions

Adding a new value into the struct causes an ABI break.
Adding a new flag to the existing flags variable (below), maintains backward compatibility.

donner: Adding a new value into the struct causes an ABI break. Adding a new flag to the existing flags…
uint8_t set; /* Named instance set [0..31] */ uint8_t set; /* Named instance set [0..31] */
uint8_t spare; uint8_t spare;
uint32_t flags; uint32_t flags;
Context not available.