Page MenuHomeFreeBSD
Differential D41324

iflib: Fix white space and reduce some line lengths
ClosedPublic
Actions

Authored by erj on Aug 4 2023, 6:03 PM.
Tags
None
Referenced Files
F161207028: D41324.diff
Wed, Jul 1, 4:00 PM
Unknown Object (File)
Wed, Jul 1, 1:21 AM
Unknown Object (File)
Mon, Jun 22, 2:17 PM
Unknown Object (File)
May 18 2026, 7:06 PM
Unknown Object (File)
May 18 2026, 7:06 PM
Unknown Object (File)
May 18 2026, 4:53 AM
Unknown Object (File)
May 17 2026, 6:36 PM
Unknown Object (File)
May 14 2026, 10:22 PM
View All Files
Subscribers
ae
glebius
imp
marius
melifaro

Details

Reviewers
shurd
kbowling
Group Reviewers
iflib
Commits
rGdadd804ded83: iflib: Fix white space and reduce some line lengths
rG7f527d48124b: iflib: Fix white space and reduce some line lengths
Summary

Signed-off-by: Eric Joyner <erj@FreeBSD.org>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52980
Build 49871: arc lint + arc unit

Event Timeline

erj created this revision.Aug 4 2023, 6:03 PM
Herald added a reviewer: shurd. · View Herald TranscriptAug 4 2023, 6:03 PM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript
erj requested review of this revision.Aug 4 2023, 6:03 PM
Harbormaster completed remote builds in B52980: Diff 125595.Aug 4 2023, 6:03 PM
erj added a child revision: D41325: iflib: Remove redundant variable.Aug 4 2023, 6:05 PM
erj mentioned this in D39930: iflib: Add subinterface interrupt allocation function.Aug 4 2023, 6:17 PM
kbowling accepted this revision.Aug 4 2023, 6:47 PM
This revision is now accepted and ready to land.Aug 4 2023, 6:47 PM
marius added a subscriber: marius.Aug 4 2023, 6:57 PM

This change doesn't acutally fix white space violations but introduces additional ones as according to style(9): 'Second level indents are four spaces'.

erj added a comment.Aug 4 2023, 7:10 PM
In D41324#941005, @marius wrote:

This change doesn't acutally fix white space violations but introduces additional ones as according to style(9): 'Second level indents are four spaces'.

It's "fix" in the context of whatever style the existing iflib code uses; if you want style(9) adherence, someone should probably re-write the iflib code to match it.

Closed by commit rG7f527d48124b: iflib: Fix white space and reduce some line lengths (authored by erj). · Explain WhyAug 7 2023, 10:47 PM
This revision was automatically updated to reflect the committed changes.
erj added a commit: rG7f527d48124b: iflib: Fix white space and reduce some line lengths.
erj added a commit: rGdadd804ded83: iflib: Fix white space and reduce some line lengths.Aug 24 2023, 9:16 PM

Revision Contents
Changeset List

PathSize
sys/
net/
7 lines
18 lines

Diff 125595

View Options

sys/net/iflib.h

Loading...
View Options

sys/net/iflib.c

Loading...