Page MenuHomeFreeBSD
Differential D40292

hwpmc: split out PMC_OP_PMCALLOCATE
ClosedPublic
Actions

Authored by mhorne on May 26 2023, 6:39 PM.
Tags
None
Referenced Files
F166764049: D40292.id123231.diff
Sun, Aug 16, 8:09 AM
Unknown Object (File)
Fri, Aug 14, 10:35 PM
Unknown Object (File)
Wed, Aug 12, 10:03 PM
Unknown Object (File)
Tue, Aug 11, 10:01 PM
Unknown Object (File)
Sun, Aug 9, 10:13 PM
Unknown Object (File)
Sat, Aug 8, 5:08 PM
Unknown Object (File)
Sun, Aug 2, 1:03 AM
Unknown Object (File)
Thu, Jul 30, 4:55 PM
View All Files
Subscribers
imp

Details

Reviewers
jkoshy
emaste
gnn
Group Reviewers
pmc
Commits
rGc514a571af74: hwpmc: split out PMC_OP_PMCALLOCATE
Summary

This is the biggest one.

Flip the return values of the pmc_can_allocate_row() and
pmc_can_allocate_rowindex() functions to boolean types, like their
naming implies. We weren't actually using the error codes they were
returning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51720
Build 48611: arc lint + arc unit

Event Timeline

mhorne created this revision.May 26 2023, 6:39 PM
Herald added a reviewer: gnn. · View Herald TranscriptMay 26 2023, 6:39 PM
Herald added a subscriber: imp. · View Herald Transcript
mhorne requested review of this revision.May 26 2023, 6:39 PM
Harbormaster completed remote builds in B51720: Diff 122494.May 26 2023, 6:39 PM
mhorne added a parent revision: D40291: hwpmc: split out PMC_OP_PMCATTACH/PMC_OP_PMCDETACH.May 26 2023, 6:39 PM
mhorne added a child revision: D40293: hwpmc: split out PMC_OP_PMCRELEASE.
jkoshy accepted this revision.Jun 13 2023, 7:18 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3459

Setting pmc to NULL seems redundant.

This revision is now accepted and ready to land.Jun 13 2023, 7:18 AM
Closed by commit rGc514a571af74: hwpmc: split out PMC_OP_PMCALLOCATE (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.
mhorne added a commit: rGc514a571af74: hwpmc: split out PMC_OP_PMCALLOCATE.

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
524 lines

Diff 122494

View Options

sys/dev/hwpmc/hwpmc_mod.c

Loading...