Differential D38360

jail: Use atomic(9) instead of CK atomics
ClosedPublic
Actions

Authored by markj on Feb 2 2023, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 5:06 PM

	Unknown Object (File)
	Mon, Jan 27, 4:57 PM

	Unknown Object (File)
	Fri, Jan 24, 10:20 AM

	Unknown Object (File)
	Fri, Jan 24, 7:32 AM

	Unknown Object (File)
	Fri, Jan 24, 3:18 AM

	Unknown Object (File)
	Thu, Jan 23, 1:45 AM

	Unknown Object (File)
	Thu, Jan 9, 6:59 PM

	Unknown Object (File)
	Nov 20 2024, 4:01 AM

View All 68 Files

Subscribers

Details

Reviewers

glebius
mjg

Group Reviewers

Commits

rG27202b98dc2d: jail: Use atomic(9) instead of CK atomics

Summary

There's no reason to use one over the other here, let's prefer the
interface that's used elsewhere in the kernel.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49496
Build 46386: arc lint + arc unit

Event Timeline

markj created this revision.Feb 2 2023, 10:41 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2023, 10:41 PM

markj requested review of this revision.Feb 2 2023, 10:41 PM

Harbormaster completed remote builds in B49496: Diff 116371.Feb 2 2023, 10:41 PM

markj added a parent revision: D38359: inpcb: Deduplicate some assertions.Feb 2 2023, 10:41 PM

markj added a child revision: D38361: inpcb: Assert against wildcard addrs in in_pcblookup_hash_locked().

My motivation to use these primitives was his: "The network epoch protects some ck lists, now it is going to also protect some pointers, so let's use ck primitive for that.". I don't have any strong opinion on this. So I neither approve nor block this change. No objection from me.

mjg accepted this revision.Feb 3 2023, 6:11 PM

This revision is now accepted and ready to land.Feb 3 2023, 6:11 PM

Closed by commit rG27202b98dc2d: jail: Use atomic(9) instead of CK atomics (authored by markj). · Explain WhyFeb 7 2023, 8:12 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG27202b98dc2d: jail: Use atomic(9) instead of CK atomics.

Revision Contents
Changeset List

Path

Size

sys/

kern/

4 lines

Diff 116371

sys/kern/kern_jail.c

Loading...