inpcb: Deduplicate some assertions
ClosedPublic
Actions

Authored by markj on Feb 2 2023, 10:41 PM.

Tags

None

Referenced Files

	F139417297: D38359.diff
	Thu, Dec 11, 8:38 PM

	Unknown Object (File)
	Wed, Dec 10, 3:19 PM

	Unknown Object (File)
	Mon, Dec 1, 11:14 PM

	Unknown Object (File)
	Fri, Nov 28, 3:00 AM

	Unknown Object (File)
	Sat, Nov 22, 7:26 AM

	Unknown Object (File)
	Nov 1 2025, 7:08 AM

	Unknown Object (File)
	Oct 12 2025, 8:16 AM

	Unknown Object (File)
	Oct 11 2025, 9:37 PM

View All 79 Files

Subscribers

imp

melifaro

Details

Reviewers

glebius

Group Reviewers

network

Commits

rG675e2618ae2d: inpcb: Deduplicate some assertions

Summary

It makes more sense to check lookupflags in the function which actually
uses SMR. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Feb 2 2023, 10:41 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptFeb 2 2023, 10:41 PM

markj requested review of this revision.Feb 2 2023, 10:41 PM

Harbormaster completed remote builds in B49495: Diff 116370.Feb 2 2023, 10:41 PM

markj added a child revision: D38360: jail: Use atomic(9) instead of CK atomics.Feb 2 2023, 10:41 PM

glebius accepted this revision.Feb 2 2023, 11:51 PM

This revision is now accepted and ready to land.Feb 2 2023, 11:51 PM

Closed by commit rG675e2618ae2d: inpcb: Deduplicate some assertions (authored by markj). · Explain WhyFeb 3 2023, 4:52 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG675e2618ae2d: inpcb: Deduplicate some assertions.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

17 lines

netinet6/

in6_pcb.c

17 lines

Diff 116430

View Options

sys/netinet/in_pcb.c