Differential D38204

IfAPI: Add if_altq_is_enabled() interface.
ClosedPublic
Actions

Authored by jhibbits on Jan 25 2023, 9:33 PM.

Details

Reviewers

glebius

Group Reviewers

network

Commits

rGd79539e6f2ee: IfAPI: Add if_altq_is_enabled() interface.

Summary

The only user of the ALTQ_IS_ENABLED() in a driver checks against the
ifnet queue. Abstract that all out and present the interface to check
if ALTQ is enabled on the interface.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Jan 25 2023, 9:33 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptJan 25 2023, 9:33 PM

jhibbits requested review of this revision.Jan 25 2023, 9:33 PM

Harbormaster completed remote builds in B49237: Diff 115740.Jan 25 2023, 9:33 PM

glebius added inline comments.Jan 31 2023, 4:45 PM

sys/net/if_var.h
649	Why do we need extern keyword here?

jhibbits added inline comments.Jan 31 2023, 4:50 PM

sys/net/if_var.h
649	We don't. It's gone.

glebius accepted this revision.Jan 31 2023, 5:06 PM

This revision is now accepted and ready to land.Jan 31 2023, 5:06 PM

Closed by commit rGd79539e6f2ee: IfAPI: Add if_altq_is_enabled() interface. (authored by jhibbits). · Explain WhyJan 31 2023, 8:04 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rGd79539e6f2ee: IfAPI: Add if_altq_is_enabled() interface..

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

6 lines

if_var.h

2 lines

Diff 116131

View Options

sys/net/if.c