Page MenuHomeFreeBSD
Differential D35173

kerneldump: remove physical argument from d_dumper
ClosedPublic
Actions

Authored by mhorne on May 11 2022, 5:29 PM.
Tags
None
Referenced Files
F138051825: D35173.id105942.diff
Fri, Nov 28, 12:39 PM
Unknown Object (File)
Thu, Nov 27, 6:29 PM
Unknown Object (File)
Sat, Nov 22, 10:12 AM
Unknown Object (File)
Fri, Nov 21, 8:50 AM
Unknown Object (File)
Sat, Nov 15, 2:02 AM
Unknown Object (File)
Wed, Nov 12, 6:20 PM
Unknown Object (File)
Tue, Nov 11, 5:59 AM
Unknown Object (File)
Thu, Oct 30, 2:17 PM
View All Files
Subscribers
dab
glebius
melifaro

Details

Reviewers
markj
imp
jhb
Group Reviewers
cam
Commits
rGe06f07bc3f48: kerneldump: remove physical argument from d_dumper
rG489ba2223676: kerneldump: remove physical argument from d_dumper
Summary

The physical address argument is essentially ignored by every dumper
method. In addition, the dump routines don't actually pass a real
address; every call to dump_append() passes a value of zero for
physical.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45530
Build 42418: arc lint + arc unit

Event Timeline

mhorne created this revision.May 11 2022, 5:29 PM
Herald added a reviewer: cam. · View Herald TranscriptMay 11 2022, 5:29 PM
Herald added subscribers: glebius, ehem_freebsd_m5p.com, dab, melifaro. · View Herald Transcript
mhorne requested review of this revision.May 11 2022, 5:29 PM
Harbormaster completed remote builds in B45530: Diff 105861.May 11 2022, 5:29 PM
mhorne added a child revision: D35174: kerneldump: remove physical from dump routines.May 11 2022, 5:29 PM
mhorne mentioned this in D35174: kerneldump: remove physical from dump routines.May 11 2022, 5:30 PM
markj accepted this revision.May 12 2022, 1:03 PM

Thanks! Yeah this parameter was never used as far as I could tell, and stopped making sense when support for compression was added.

This revision is now accepted and ready to land.May 12 2022, 1:03 PM
ehem_freebsd_m5p.com removed a subscriber: ehem_freebsd_m5p.com.May 13 2022, 3:07 AM
Closed by commit rG489ba2223676: kerneldump: remove physical argument from d_dumper (authored by mhorne). · Explain WhyMay 13 2022, 1:45 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG489ba2223676: kerneldump: remove physical argument from d_dumper.
mhorne added a commit: rGe06f07bc3f48: kerneldump: remove physical argument from d_dumper.Jun 27 2022, 7:36 PM

Revision Contents
Changeset List

PathSize
sys/
cam/
ata/
4 lines
nvme/
4 lines
scsi/
4 lines
dev/
aac/
6 lines
ida/
2 lines
ips/
6 lines
mfi/
2 lines
3 lines
mmc/
6 lines
nvd/
2 lines
virtio/
block/
5 lines
xen/
blkfront/
3 lines
geom/
nop/
3 lines
raid/
4 lines
14 lines
1 line
6 lines
6 lines
7 lines
8 lines
4 lines
kern/
2 lines
4 lines
netinet/
netdump/
5 lines
sys/
1 line

Diff 105861

View Options

sys/cam/ata/ata_da.c

Loading...
View Options

sys/cam/nvme/nvme_da.c

Loading...
View Options

sys/cam/scsi/scsi_da.c

Loading...
View Options

sys/dev/aac/aac_disk.c

Loading...
View Options

sys/dev/ida/ida_disk.c

Loading...
View Options

sys/dev/ips/ips_disk.c

Loading...
View Options

sys/dev/mfi/mfi_disk.c

Loading...
View Options

sys/dev/mfi/mfi_syspd.c

Loading...
View Options

sys/dev/mmc/mmcsd.c

Loading...
View Options

sys/dev/nvd/nvd.c

Loading...
View Options

sys/dev/virtio/block/virtio_blk.c

Loading...
View Options

sys/dev/xen/blkfront/blkfront.c

Loading...
View Options

sys/geom/nop/g_nop.c

Loading...
View Options

sys/geom/raid/g_raid.h

Loading...
View Options

sys/geom/raid/g_raid.c

Loading...
View Options

sys/geom/raid/g_raid_tr_if.m

Loading...
View Options

sys/geom/raid/tr_concat.c

Loading...
View Options

sys/geom/raid/tr_raid0.c

Loading...
View Options

sys/geom/raid/tr_raid1.c

Loading...
View Options

sys/geom/raid/tr_raid1e.c

Loading...
View Options

sys/geom/raid/tr_raid5.c

Loading...
View Options

sys/kern/kern_shutdown.c

Loading...
View Options

sys/kern/kern_vnodedumper.c

Loading...
View Options

sys/netinet/netdump/netdump_client.c

Loading...
View Options

sys/sys/conf.h

Loading...