Differential D35174

kerneldump: remove physical from dump routines
ClosedPublic
Actions

Authored by mhorne on May 11 2022, 5:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 21, 5:40 PM

	Unknown Object (File)
	Sun, Apr 13, 8:52 PM

	Unknown Object (File)
	Wed, Apr 9, 1:50 AM

	Unknown Object (File)
	Mar 20 2025, 3:11 PM

	Unknown Object (File)
	Feb 22 2025, 5:21 PM

	Unknown Object (File)
	Feb 22 2025, 2:18 PM

	Unknown Object (File)
	Feb 22 2025, 2:08 PM

	Unknown Object (File)
	Feb 22 2025, 2:01 PM

View All 84 Files

Subscribers

Details

Reviewers

markj
imp
jhb
manu

Commits

rG5a96b88f05d1: kerneldump: remove physical from dump routines
rGdb71383b8836: kerneldump: remove physical from dump routines

Summary

It is unused, especially now that the underlying d_dumper methods do not
accept the argument.

Test Plan

To be tinderboxed alongside D35173.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 11 2022, 5:29 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 11 2022, 5:29 PM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B45531: Diff 105862.May 11 2022, 5:29 PM

mhorne requested review of this revision.May 11 2022, 5:29 PM

mhorne added a parent revision: D35173: kerneldump: remove physical argument from d_dumper.

mhorne edited the test plan for this revision. (Show Details)May 11 2022, 5:30 PM

markj accepted this revision.May 12 2022, 1:04 PM

This revision is now accepted and ready to land.May 12 2022, 1:04 PM

Closed by commit rGdb71383b8836: kerneldump: remove physical from dump routines (authored by mhorne). · Explain WhyMay 13 2022, 1:45 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGdb71383b8836: kerneldump: remove physical from dump routines.

mhorne added a commit: rG5a96b88f05d1: kerneldump: remove physical from dump routines.Jun 27 2022, 7:36 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

minidump_machdep.c

4 lines

arm/

arm/

minidump_machdep.c

4 lines

arm64/

arm64/

minidump_machdep.c

4 lines

ddb/

4 lines

geom/

raid/

6 lines

i386/

i386/

minidump_machdep_base.c

4 lines

kern/

8 lines

kern_shutdown.c

39 lines

powerpc/

powerpc/

minidump_machdep.c

4 lines

riscv/

riscv/

minidump_machdep.c

4 lines

sys/

4 lines

Diff 105943

sys/amd64/amd64/minidump_machdep.c

	SHA256 (rustc-1.7.0-src.tar.gz) = 6df96059d87b718676d9cd879672e4e22418b6093396b4ccb5b5b66df37bf13a			SHA256 (rustc-1.8.0-src.tar.gz) = af4466147e8d4db4de2a46e07494d2dc2d96313c5b37da34237f511c905f7449
	SIZE (rustc-1.7.0-src.tar.gz) = 25097611			SIZE (rustc-1.8.0-src.tar.gz) = 25641320
	SHA256 (rust-stage0-2015-12-18-3391630-freebsd-i386-7e624c50494402e1feb14c743d659fbd71b448f5.tar.bz2) = 80b8faebc3a917bc83c02a98028e6d0284709d60973e5261555c3126869009b1			SHA256 (rust-stage0-2016-02-17-4d3eebf-freebsd-i386-4e2af0b34eb335e173aebff543be693724a956c2.tar.bz2) = 578be492263cf9512020662fa35a493ec0589870e9de2e45e0aa63d40f515a3e
	SIZE (rust-stage0-2015-12-18-3391630-freebsd-i386-7e624c50494402e1feb14c743d659fbd71b448f5.tar.bz2) = 15436433			SIZE (rust-stage0-2016-02-17-4d3eebf-freebsd-i386-4e2af0b34eb335e173aebff543be693724a956c2.tar.bz2) = 17417438

sys/arm/arm/minidump_machdep.c

	SHA256 (rustc-1.7.0-src.tar.gz) = 6df96059d87b718676d9cd879672e4e22418b6093396b4ccb5b5b66df37bf13a			SHA256 (rustc-1.8.0-src.tar.gz) = af4466147e8d4db4de2a46e07494d2dc2d96313c5b37da34237f511c905f7449
	SIZE (rustc-1.7.0-src.tar.gz) = 25097611			SIZE (rustc-1.8.0-src.tar.gz) = 25641320
	SHA256 (rust-stage0-2015-12-18-3391630-freebsd-i386-7e624c50494402e1feb14c743d659fbd71b448f5.tar.bz2) = 80b8faebc3a917bc83c02a98028e6d0284709d60973e5261555c3126869009b1			SHA256 (rust-stage0-2016-02-17-4d3eebf-freebsd-i386-4e2af0b34eb335e173aebff543be693724a956c2.tar.bz2) = 578be492263cf9512020662fa35a493ec0589870e9de2e45e0aa63d40f515a3e
	SIZE (rust-stage0-2015-12-18-3391630-freebsd-i386-7e624c50494402e1feb14c743d659fbd71b448f5.tar.bz2) = 15436433			SIZE (rust-stage0-2016-02-17-4d3eebf-freebsd-i386-4e2af0b34eb335e173aebff543be693724a956c2.tar.bz2) = 17417438

sys/arm64/arm64/minidump_machdep.c

	SHA256 (rustc-1.7.0-src.tar.gz) = 6df96059d87b718676d9cd879672e4e22418b6093396b4ccb5b5b66df37bf13a			SHA256 (rustc-1.8.0-src.tar.gz) = af4466147e8d4db4de2a46e07494d2dc2d96313c5b37da34237f511c905f7449
	SIZE (rustc-1.7.0-src.tar.gz) = 25097611			SIZE (rustc-1.8.0-src.tar.gz) = 25641320
	SHA256 (rust-stage0-2015-12-18-3391630-freebsd-i386-7e624c50494402e1feb14c743d659fbd71b448f5.tar.bz2) = 80b8faebc3a917bc83c02a98028e6d0284709d60973e5261555c3126869009b1			SHA256 (rust-stage0-2016-02-17-4d3eebf-freebsd-i386-4e2af0b34eb335e173aebff543be693724a956c2.tar.bz2) = 578be492263cf9512020662fa35a493ec0589870e9de2e45e0aa63d40f515a3e
	SIZE (rust-stage0-2015-12-18-3391630-freebsd-i386-7e624c50494402e1feb14c743d659fbd71b448f5.tar.bz2) = 15436433			SIZE (rust-stage0-2016-02-17-4d3eebf-freebsd-i386-4e2af0b34eb335e173aebff543be693724a956c2.tar.bz2) = 17417438

sys/ddb/db_textdump.c

	SHA256 (rustc-1.7.0-src.tar.gz) = 6df96059d87b718676d9cd879672e4e22418b6093396b4ccb5b5b66df37bf13a			SHA256 (rustc-1.8.0-src.tar.gz) = af4466147e8d4db4de2a46e07494d2dc2d96313c5b37da34237f511c905f7449
	SIZE (rustc-1.7.0-src.tar.gz) = 25097611			SIZE (rustc-1.8.0-src.tar.gz) = 25641320
	SHA256 (rust-stage0-2015-12-18-3391630-freebsd-i386-7e624c50494402e1feb14c743d659fbd71b448f5.tar.bz2) = 80b8faebc3a917bc83c02a98028e6d0284709d60973e5261555c3126869009b1			SHA256 (rust-stage0-2016-02-17-4d3eebf-freebsd-i386-4e2af0b34eb335e173aebff543be693724a956c2.tar.bz2) = 578be492263cf9512020662fa35a493ec0589870e9de2e45e0aa63d40f515a3e
	SIZE (rust-stage0-2015-12-18-3391630-freebsd-i386-7e624c50494402e1feb14c743d659fbd71b448f5.tar.bz2) = 15436433			SIZE (rust-stage0-2016-02-17-4d3eebf-freebsd-i386-4e2af0b34eb335e173aebff543be693724a956c2.tar.bz2) = 17417438

sys/geom/raid/g_raid.c

Loading...

sys/i386/i386/minidump_machdep_base.c

Loading...

sys/kern/kern_dump.c

Loading...

sys/kern/kern_shutdown.c

Loading...

sys/powerpc/powerpc/minidump_machdep.c

Loading...

sys/riscv/riscv/minidump_machdep.c

Loading...

sys/sys/conf.h

Loading...