kerneldump: remove physical argument from d_dumper
ClosedPublic
Actions

Authored by mhorne on May 11 2022, 5:29 PM.

Details

Reviewers

markj
imp
jhb

Group Reviewers

cam

Commits

rGe06f07bc3f48: kerneldump: remove physical argument from d_dumper
rG489ba2223676: kerneldump: remove physical argument from d_dumper

Summary

The physical address argument is essentially ignored by every dumper
method. In addition, the dump routines don't actually pass a real
address; every call to dump_append() passes a value of zero for
physical.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 11 2022, 5:29 PM

Herald added a reviewer: cam. · View Herald TranscriptMay 11 2022, 5:29 PM

Herald added subscribers: glebius, ehem_freebsd_m5p.com, dab, melifaro. · View Herald Transcript

mhorne requested review of this revision.May 11 2022, 5:29 PM

Harbormaster completed remote builds in B45530: Diff 105861.May 11 2022, 5:29 PM

mhorne added a child revision: D35174: kerneldump: remove physical from dump routines.May 11 2022, 5:29 PM

mhorne mentioned this in D35174: kerneldump: remove physical from dump routines.May 11 2022, 5:30 PM

Thanks! Yeah this parameter was never used as far as I could tell, and stopped making sense when support for compression was added.

This revision is now accepted and ready to land.May 12 2022, 1:03 PM

ehem_freebsd_m5p.com removed a subscriber: ehem_freebsd_m5p.com.May 13 2022, 3:07 AM

Closed by commit rG489ba2223676: kerneldump: remove physical argument from d_dumper (authored by mhorne). · Explain WhyMay 13 2022, 1:45 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG489ba2223676: kerneldump: remove physical argument from d_dumper.

mhorne added a commit: rGe06f07bc3f48: kerneldump: remove physical argument from d_dumper.Jun 27 2022, 7:36 PM

Revision Contents
Changeset List

Path

Size

sys/

cam/

ata/

ata_da.c

4 lines

mmc/

mmc_da.c

3 lines

nvme/

nvme_da.c

4 lines

scsi/

scsi_da.c

4 lines

dev/

aac/

aac_disk.c

6 lines

ida/

ida_disk.c

2 lines

ips/

ips_disk.c

6 lines

mfi/

mfi_disk.c

2 lines

mfi_syspd.c

3 lines

mmc/

mmcsd.c

6 lines

nvd/

nvd.c

2 lines

virtio/

block/

virtio_blk.c

5 lines

xen/

blkfront/

blkfront.c

3 lines

geom/

nop/

g_nop.c

3 lines

raid/

4 lines

14 lines

1 line

6 lines

6 lines

7 lines

8 lines

4 lines

union/

g_union.c

5 lines

kern/

kern_shutdown.c

2 lines

kern_vnodedumper.c

4 lines

netinet/

netdump/

netdump_client.c

6 lines

sys/

conf.h

1 line

Diff 105942

View Options

sys/cam/ata/ata_da.c

View Options

sys/cam/mmc/mmc_da.c

View Options

sys/cam/nvme/nvme_da.c

View Options

sys/cam/scsi/scsi_da.c

View Options

sys/dev/aac/aac_disk.c

View Options

sys/dev/ida/ida_disk.c

View Options

sys/dev/ips/ips_disk.c

View Options

sys/dev/mfi/mfi_disk.c

View Options

sys/dev/mfi/mfi_syspd.c

View Options

sys/dev/mmc/mmcsd.c

View Options

sys/dev/nvd/nvd.c

View Options

sys/dev/virtio/block/virtio_blk.c

View Options

sys/dev/xen/blkfront/blkfront.c

View Options

sys/geom/nop/g_nop.c

View Options

sys/geom/raid/g_raid.h

View Options

sys/geom/raid/g_raid.c

View Options

sys/geom/raid/g_raid_tr_if.m

View Options

sys/geom/raid/tr_concat.c

View Options

sys/geom/raid/tr_raid0.c

View Options

sys/geom/raid/tr_raid1.c

View Options

sys/geom/raid/tr_raid1e.c

View Options

sys/geom/raid/tr_raid5.c

View Options

sys/geom/union/g_union.c

View Options

sys/kern/kern_shutdown.c

View Options

sys/kern/kern_vnodedumper.c

View Options

sys/netinet/netdump/netdump_client.c

View Options

kerneldump: remove physical argument from d_dumperClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 105942

sys/cam/ata/ata_da.c

sys/cam/mmc/mmc_da.c

sys/cam/nvme/nvme_da.c

sys/cam/scsi/scsi_da.c

sys/dev/aac/aac_disk.c

sys/dev/ida/ida_disk.c

sys/dev/ips/ips_disk.c

sys/dev/mfi/mfi_disk.c

sys/dev/mfi/mfi_syspd.c

sys/dev/mmc/mmcsd.c

sys/dev/nvd/nvd.c

sys/dev/virtio/block/virtio_blk.c

sys/dev/xen/blkfront/blkfront.c

sys/geom/nop/g_nop.c

sys/geom/raid/g_raid.h

sys/geom/raid/g_raid.c

sys/geom/raid/g_raid_tr_if.m

sys/geom/raid/tr_concat.c

sys/geom/raid/tr_raid0.c

sys/geom/raid/tr_raid1.c

sys/geom/raid/tr_raid1e.c

sys/geom/raid/tr_raid5.c

sys/geom/union/g_union.c

sys/kern/kern_shutdown.c

sys/kern/kern_vnodedumper.c

sys/netinet/netdump/netdump_client.c

sys/sys/conf.h

kerneldump: remove physical argument from d_dumper
ClosedPublic
Actions

Revision Contents
Changeset List