Page MenuHomeFreeBSD
Differential D33570

bhyve nvme: Remove redundant AER Limit checks
ClosedPublic
Actions

Authored by chuck on Dec 19 2021, 4:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 30, 11:06 AM
Unknown Object (File)
Tue, Jul 28, 6:14 PM
Unknown Object (File)
Sun, Jul 26, 3:14 PM
Unknown Object (File)
Fri, Jul 24, 8:12 PM
Unknown Object (File)
Thu, Jul 23, 1:40 AM
Unknown Object (File)
Wed, Jul 22, 5:05 PM
Unknown Object (File)
Jun 26 2026, 5:08 AM
Unknown Object (File)
May 22 2026, 1:50 PM
View All Files
Subscribers
allanjude
bcran
dab
rgrimes

Details

Reviewers
grehan
jhb
imp
rpokala
allanjude
Group Reviewers
bhyve
Commits
rG45ab4076f36b: bhyve nvme: Remove redundant AER Limit checks
Summary

The NVMe emulation checked if the Asynchronous Event Request Limit
(a.k.a AERL) would be exceeded in pci_nvme_aer_add(), but this function
is only called from nvme_opc_async_event_req() which also checks for
exceeding the AERL.

While in the neighborhood, fix / enhance the debug logging.

Tested by:
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43483
Build 40371: arc lint + arc unit

Event Timeline

chuck created this revision.Dec 19 2021, 4:17 PM
Herald added a reviewer: bhyve. · View Herald TranscriptDec 19 2021, 4:17 PM
Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript
chuck requested review of this revision.Dec 19 2021, 4:17 PM
Harbormaster completed remote builds in B43483: Diff 100299.Dec 19 2021, 4:17 PM
chuck added a parent revision: D33569: bhyve nvme: Add missing Admin opcodes.Dec 19 2021, 4:17 PM
chuck added a child revision: D33571: bhyve nvme: Fix Set Features.
allanjude accepted this revision.Dec 23 2021, 5:16 PM
allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:16 PM
imp accepted this revision.Dec 23 2021, 7:24 PM

I don't see the 'while in the area' changes, so omit that from the final commit message.

chuck added a comment.Jan 29 2022, 8:24 PM
In D33570#759866, @imp wrote:

I don't see the 'while in the area' changes, so omit that from the final commit message.

Good catch. Fixed.

Closed by commit rG45ab4076f36b: bhyve nvme: Remove redundant AER Limit checks (authored by chuck). · Explain WhyJan 29 2022, 11:17 PM
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rG45ab4076f36b: bhyve nvme: Remove redundant AER Limit checks.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
3 lines

Diff 100299

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...