Page MenuHomeFreeBSD

net: Use M_HASHTYPE_OPAQUE_HASH if the mbuf flowid has hash properties
ClosedPublic

Authored by sepherosa_gmail.com on Jun 2 2016, 3:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 30, 1:55 AM
Unknown Object (File)
Apr 29 2024, 7:13 PM
Unknown Object (File)
Apr 29 2024, 6:34 PM
Unknown Object (File)
Mar 31 2024, 6:22 AM
Unknown Object (File)
Feb 16 2024, 4:06 PM
Unknown Object (File)
Feb 16 2024, 6:17 AM
Unknown Object (File)
Feb 16 2024, 5:16 AM
Unknown Object (File)
Jan 19 2024, 12:23 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to net: Use M_HASHTYPE_OPAQUE_HASH if the mbuf flowid has hash properties.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
hselasky edited edge metadata.

OK with regard to mlx5

This revision is now accepted and ready to land.Jun 2 2016, 7:35 AM
tuexen edited edge metadata.

OK for the SCTP changes

erj edited edge metadata.

The intel driver changes look ok to me, but what's the reason behind indicating that the hash that comes out of the card has hash properties? (I guess this might be covered in previous reviews or commit messages)

In D6688#141142, @erj wrote:

The intel driver changes look ok to me, but what's the reason behind indicating that the hash that comes out of the card has hash properties? (I guess this might be covered in previous reviews or commit messages)

At first, it's added mainly for the patch in this review:
https://reviews.freebsd.org/D6689

But it turns out that it also corrects certain types of mbuf hash type checks or makes the checks resilient to future hash type changes, e.g. the if_vxlan change in this patch.

And I think it could also be used in other places in the future :)

This revision was automatically updated to reflect the committed changes.