bhyve: add configurable SMBIOS OEM Strings
Needs ReviewPublic
Actions

Authored by chuck on Wed, Jun 10, 12:58 AM.

Details

Reviewers

markj
corvink

Group Reviewers

bhyve

Summary

Add the option "oemstring" to allow setting the DMI type 11 ("OEM
Strings") SMBIOS structure. These are free-form strings, available for
any purpose, but can be especially useful to pass configuration,
secrets, and credential information into a Linux guest and consumed by
systemd.

MFC after: 1 month
Relnotes: yes

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73778
Build 70661: arc lint + arc unit

Event Timeline

chuck created this revision.Wed, Jun 10, 12:58 AM

Herald added a reviewer: bhyve. · View Herald TranscriptWed, Jun 10, 12:58 AM

Herald added subscribers: ziaee, bcran, rgrimes, imp. · View Herald Transcript

chuck requested review of this revision.Wed, Jun 10, 12:58 AM

Harbormaster completed remote builds in B73778: Diff 179530.Wed, Jun 10, 12:58 AM

markj added inline comments.Fri, Jun 12, 1:28 AM

usr.sbin/bhyve/smbiostbl.c
259	If `nstrings` is a uint8_t, how can we support 99999 OEM strings?
491
492
829	Why not report an error instead?
839	Again, why not report malformed input instead of silently ignoring it?
855	Why not report this case as an error?
881	Better to use calloc().
908
919	`template_strings` doesn't get freed anywhere.
927	To me this is clearer as for (i = 0; template_strings[i].node != NULL; i++) ;
933	Spurious change.