ifnet: Fix decreasing the vnet interface count
ClosedPublic
Actions

Authored by zlei on Mon, Mar 16, 3:44 AM.

Details

Reviewers

kp
pouria

Group Reviewers

network

Commits

rG2265cf938ec3: ifnet: Fix decreasing the vnet interface count
rG47339e4a9209: ifnet: Fix decreasing the vnet interface count
rG1b7687f053af: ifnet: Fix decreasing the vnet interface count
rG8065ff63c0e5: ifnet: Fix decreasing the vnet interface count

Summary

It should be decreased only when the interface has been successfully
removed from the "active" list.

This prevents vnet_if_return() from potential OOB writes to the
allocated memory "pending".

Fixes: a779388f8bb3 if: Protect V_ifnet in vnet_if_return()
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Mon, Mar 16, 3:44 AM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptMon, Mar 16, 3:44 AM

zlei requested review of this revision.Mon, Mar 16, 3:44 AM

kp accepted this revision as: kp.Mon, Mar 16, 8:28 AM

This revision is now accepted and ready to land.Mon, Mar 16, 8:28 AM

pouria accepted this revision as: pouria.Mon, Mar 16, 8:46 AM

Closed by commit rG8065ff63c0e5: ifnet: Fix decreasing the vnet interface count (authored by zlei). · Explain WhyMon, Mar 16, 4:23 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG8065ff63c0e5: ifnet: Fix decreasing the vnet interface count.

zlei added a commit: rG1b7687f053af: ifnet: Fix decreasing the vnet interface count.Fri, Mar 20, 10:01 AM

zlei added a commit: rG47339e4a9209: ifnet: Fix decreasing the vnet interface count.

zlei added a commit: rG2265cf938ec3: ifnet: Fix decreasing the vnet interface count.Fri, Mar 20, 10:04 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

6 lines

Diff 173753

View Options

ifnet: Fix decreasing the vnet interface countClosedPublicActions