kern/vfs_unmount.c: promote flags to uint64_t
ClosedPublic
Actions

Authored by kib on Mon, Feb 9, 6:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 11, 8:49 AM

	Unknown Object (File)
	Wed, Feb 11, 8:44 AM

	Unknown Object (File)
	Wed, Feb 11, 7:46 AM

	Unknown Object (File)
	Wed, Feb 11, 4:01 AM

	Unknown Object (File)
	Wed, Feb 11, 3:37 AM

	Unknown Object (File)
	Wed, Feb 11, 3:26 AM

	Unknown Object (File)
	Tue, Feb 10, 1:23 PM

	Unknown Object (File)
	Tue, Feb 10, 3:39 AM

Subscribers

imp

olce

Details

Reviewers

jah

Commits

rG8066b8923ebf: kern/vfs_unmount.c: promote flags to uint64_t

Summary

to prevent sign-extension, causing unexpected flags to be passed to
dounmount().  The mnt_flags and MNT_* constants are 64bit wide.

Siggested by:   jah

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Mon, Feb 9, 6:12 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, Feb 9, 6:12 PM

kib requested review of this revision.Mon, Feb 9, 6:12 PM

jah accepted this revision.Mon, Feb 9, 6:34 PM

This revision is now accepted and ready to land.Mon, Feb 9, 6:34 PM

Closed by commit rG8066b8923ebf: kern/vfs_unmount.c: promote flags to uint64_t (authored by kib). · Explain WhyMon, Feb 9, 6:49 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG8066b8923ebf: kern/vfs_unmount.c: promote flags to uint64_t.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_file.c

2 lines

kern/

vfs_mount.c

4 lines

sys/

syscallsubr.h

2 lines

Diff 171575

View Options

sys/compat/linux/linux_file.c

View Options

sys/kern/vfs_mount.c

View Options

kern/vfs_unmount.c: promote flags to uint64_tClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 171575

sys/compat/linux/linux_file.c

sys/kern/vfs_mount.c

sys/sys/syscallsubr.h

kern/vfs_unmount.c: promote flags to uint64_t
ClosedPublic
Actions

Revision Contents
Changeset List