Page MenuHomeFreeBSD

nvmf_che: Add a manual page for the Chelsio NVMe/TCP PDU offload driver
Needs ReviewPublic

Authored by jhb on Fri, Nov 14, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 1, 10:31 AM
Unknown Object (File)
Sat, Nov 29, 11:13 PM
Unknown Object (File)
Thu, Nov 27, 5:30 PM
Unknown Object (File)
Thu, Nov 27, 5:03 PM
Unknown Object (File)
Thu, Nov 27, 2:37 AM
Unknown Object (File)
Tue, Nov 25, 8:01 PM
Unknown Object (File)
Mon, Nov 24, 9:07 PM
Unknown Object (File)
Sun, Nov 23, 7:45 AM
Subscribers

Details

Reviewers
np
Summary

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68648
Build 65531: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Fri, Nov 14, 6:52 PM
share/man/man4/nvmf_che.4
11

This doesn't need to be quoted

15–17

This matches what we do on dozens of pages.

I like what you did here of calling it a module continuously.

share/man/man4/nvmf_che.4
15–17

Oh, I just copied this from nvmf_tcp.4 which uses the same markup. Presumably these nits need to be fixed in that.

share/man/man4/nvmf_che.4
15–17

Hmm, grepping in share/man/man4:

> git grep '_load="YES"' | wc -l
     504
> git grep '^\..*_load="YES"' 
acpi_wmi.4:.Dl acpi_wmi_load="YES"
mrsas.4:.Cd mrsas_load="YES"
rtsx.4:.Cd mmc_load="YES"
rtsx.4:.Cd mmcsd_load="YES"
rtsx.4:.Cd rtsx_load="YES"
u2f.4:.Cd u2f_load="YES"
umb.4:.Cd umb_load="YES"
vmm.4:.Cd vmm_load="YES"
wpi.4:.Dl if_wpi_load="YES"

Given the description of .Cd in mode(7) it seems like it should be used for device foo but not loader.conf entries.

Also, existing pages (which use prose) still indent these lines via a \.Bd block which I think we are stuck with until we settle on a format that doesn't use prose.