net80211: migrate if_flags, if_drvflags out of most source files

[adrian]

Summary

Migrate both if_flags and if_drvflags out of most source files.
Ideally it'd only be referenced in ieee80211_freebsd.c, but for now
it also ignores references in ieee80211_ioctl.c.

• migrate if_flags set to if_setflags
• migrate if_flags get to if_getflags
• migrate if_drvflags get to if_getdrvflags
• add ieee80211_vap_check_is_monitor() and ieee8021_vap_check_is_simplex() to abstract out the IFF_MONITOR and IFF_SIMPLEX flag checks.

[adrian]

add some more stuff

[bz]

sys/net80211/ieee80211_freebsd.c

1273

You can save yourself the local variable here and all the way down.

1275

No. Stop for a bool. Also would belong inside ().

style.9 says return ((if_getflags(ifp) & IFF_MONITOR) != 0);

Here and all the way down please.

1316

This almost wants a set and a clear function. I'd at least call the argument set and not state to make it clearer.

sys/net80211/ieee80211_freebsd.h

265–267

While here you could make it style clean and check != 0

sys/net80211/ieee80211_proto.c

1987

no space

[adrian]

sys/net80211/ieee80211_freebsd.c

1316

Yeah, I'm not happy with my naming scheme right now - these aren't really supposed to be public net80211 functions and their current names make them sound like drivers/tools can use them to query stuff. What they REALLY are is glue to the underlying OS interface.

Do you have any suggestions on what to name them to make that particular fact clearer? Or should I just be clearer in the documentation?

[adrian]

update from bz

[adrian]

fixed, i hope!