Differential D48240

ath_hal_ar9300: implement the TX/RX chainmask override for AR9300 HAL
ClosedPublic
Actions

Authored by adrian on Sun, Dec 29, 5:29 AM.

Details

Reviewers

None

Group Reviewers

wireless

Commits

rGcc3b7b7e715d: ath_hal_ar9300: implement the TX/RX chainmask override for AR9300 HAL

Summary

This commit implements the missing capability set handlers for
setting the transmit and receive chainmasks. I did this for the
AR5416 and later chips years ago, but not for these.

This is especially useful when you're only hooking up one or two
antennas on a 3 antenna device - or you just want to test it like
that.

It also requires updating the number of supported transmit/receive
streams, so also add them here.

Locally Tested:

AR9300, STA mode, 1, 2 and 3 stream TX/RX configuration

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 61383
Build 58267: arc lint + arc unit

Event Timeline

adrian created this revision.Sun, Dec 29, 5:29 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Dec 29, 5:29 AM

adrian requested review of this revision.Sun, Dec 29, 5:29 AM

Harbormaster completed remote builds in B61383: Diff 148509.Sun, Dec 29, 5:29 AM

adrian added a parent revision: D48239: ath_hal_ar9300: quick refactor of tx/rx chain handling.Sun, Dec 29, 5:29 AM

adrian added a reviewer: wireless.Sun, Dec 29, 5:32 AM

adrian added a project: wireless.

emaste mentioned this in D48239: ath_hal_ar9300: quick refactor of tx/rx chain handling.Sun, Dec 29, 3:05 PM

adrian added a child revision: D48248: net80211: refactor amrr_update() into HT and legacy paths.Sun, Dec 29, 7:42 PM

generally looks fine

sys/contrib/dev/ath/ath_hal/ar9300/ar9300_misc.c
1083–1085	This is the same expression as above, yes? Why is this one wrapped and the other not?
1091–1092	It's not possible for this to be true, right? It could just be assert <= 3?

adrian added inline comments.Tue, Dec 31, 1:09 AM

sys/contrib/dev/ath/ath_hal/ar9300/ar9300_misc.c
1091–1092	i'm mostly copy-pasta'ing the existing code. What I really need to do is extract owl_get_ntxchains() into the HAL layer and then reuse it everywhere, and do all the sanity checking there. (It's a BIT of a PITA because it's not txantenna == num tx streams for all chips, same as rx antenna not always num rx streams. I need to go bring more sanity to that mess.)