Page MenuHomeFreeBSD
Differential D47986

rtwn: refactor out the TX power register power dump, condense output
ClosedPublic
Actions

Authored by adrian on Dec 8 2024, 3:48 PM.
Tags
Referenced Files
F108678090: D47986.diff
Mon, Jan 27, 6:21 AM
Unknown Object (File)
Dec 26 2024, 10:23 AM
Unknown Object (File)
Dec 26 2024, 9:42 AM
Unknown Object (File)
Dec 26 2024, 9:03 AM
Unknown Object (File)
Dec 26 2024, 8:29 AM
Unknown Object (File)
Dec 26 2024, 4:22 AM
Unknown Object (File)
Dec 21 2024, 7:54 AM
Unknown Object (File)
Dec 20 2024, 2:37 PM
View All 11 Files
Subscribers
bz
imp

Details

Reviewers
imp
bz
Group Reviewers
wireless
Commits
rG6858c6b1e1a9: rtwn: refactor out the TX power register power dump, condense output
Summary
  • Refactor out the TX power register register dump - it's done in a couple places and it makes sense to refactor it.
  • Condense the output into a few lines per transmit chain. It's very long with the 8 and 16 MCS rates, and it made it difficult to eyeball what's going on when tweaking TX power.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61031
Build 57915: arc lint + arc unit

Event Timeline

adrian created this revision.Dec 8 2024, 3:48 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 8 2024, 3:48 PM
adrian requested review of this revision.Dec 8 2024, 3:48 PM
Harbormaster completed remote builds in B61031: Diff 147696.Dec 8 2024, 3:48 PM
adrian added a parent revision: D47979: rtwn: add APIs for setting transmit power.Dec 8 2024, 3:49 PM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D47987: rtwn: try enforcing net80211 regulatory / txpower limits for 11n chips.Dec 8 2024, 3:58 PM
imp accepted this revision.Dec 12 2024, 6:16 PM

This looks sane, but I don't know if it's right from a. hardware perspective.

This revision is now accepted and ready to land.Dec 12 2024, 6:16 PM
bz accepted this revision as: bz.Dec 18 2024, 10:33 AM
bz added a subscriber: bz.

Should be fine; debugging only anyway..

adrian updated this revision to Diff 148202.Dec 18 2024, 4:47 PM

update from rebase

This revision now requires review to proceed.Dec 18 2024, 4:47 PM
Harbormaster completed remote builds in B61239: Diff 148202.Dec 18 2024, 4:47 PM
bz accepted this revision as: bz.Dec 18 2024, 10:14 PM
This revision is now accepted and ready to land.Dec 18 2024, 10:14 PM
Closed by commit rG6858c6b1e1a9: rtwn: refactor out the TX power register power dump, condense output (authored by adrian). · Explain WhyDec 18 2024, 11:49 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG6858c6b1e1a9: rtwn: refactor out the TX power register power dump, condense output.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
rtl8192c/
1 line
64 lines
rtl8192e/
11 lines

Diff 147696

View Options

sys/dev/rtwn/rtl8192c/r92c.h

Loading...
View Options

sys/dev/rtwn/rtl8192c/r92c_chan.c

Loading...
View Options

sys/dev/rtwn/rtl8192e/r92e_chan.c

Loading...