Page MenuHomeFreeBSD

rtwn: fix rtl8812/rtl8821 vht definitions, add VHT calibration/rate control
ClosedPublic

Authored by adrian on Nov 27 2024, 12:07 AM.
Referenced Files
F106159760: D47774.id147015.diff
Thu, Dec 26, 9:13 AM
F106155798: D47774.id.diff
Thu, Dec 26, 7:41 AM
F106141780: D47774.id147342.diff
Thu, Dec 26, 2:20 AM
F106140888: D47774.id147014.diff
Thu, Dec 26, 1:58 AM
Unknown Object (File)
Wed, Dec 25, 4:19 PM
Unknown Object (File)
Wed, Dec 25, 9:40 AM
Unknown Object (File)
Sat, Dec 21, 8:14 AM
Unknown Object (File)
Fri, Dec 20, 5:02 AM
Subscribers

Details

Summary
  • Add support for 80MHz channels during IQ calibration
  • Correct the RAID flags for 1 and 2 stream VHT - the later ones are for 2GHz VHT and then 3/4 stream VHT
  • Add VHT to the RAID calculation for when we eventually transmit VHT rates.

Obtained from: Linux rtw88 (https://github.com/lwfinger/rtw88)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60910
Build 57794: arc lint + arc unit

Event Timeline

emaste added inline comments.
sys/dev/rtwn/rtl8812a/r12a_fw.c
174–177

Still TODO 160 MHz?

sys/dev/rtwn/rtl8812a/r12a_fw.c
174–177

Still TODO 160 MHz?

As far as I'm aware, the 8812/8821 don't do 160MHz. If someone finds evidence to the contrary then please lemme know!

bz requested changes to this revision.Thu, Nov 28, 1:11 AM
bz added a subscriber: bz.
bz added inline comments.
sys/dev/rtwn/rtl8812a/r12a_fw.c
174–177

I think the only 8821 I found with 160Mhz was a CE and that is rtw88

176

Are all VHT40 channels also marked HT40?

sys/dev/rtwn/rtl8812a/r12a_tx.c
192

could be a Phab issue but indentation is weird here.

193

don't need to make these blocks {} {}

This revision now requires changes to proceed.Thu, Nov 28, 1:11 AM
sys/dev/rtwn/rtl8812a/r12a_fw.c
176

I think so; I don't think we're fully doing greenfield VHT right now.

But honestly it's a good question for the future - going through and adding IS_CHAN_HT{20,40} || IS_CHAN_VHT{20,40} and also IS_CHAN_HT || IS_CHAN_VHT isn't a terrible idea. Lemme go look.

adrian marked an inline comment as not done.Mon, Dec 2, 6:32 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Dec 5, 7:31 AM
This revision was automatically updated to reflect the committed changes.