Page MenuHomeFreeBSD

ath: use the new net80211 methods for AMPDU density/limit, short-GI
AcceptedPublic

Authored by adrian on Mon, Nov 25, 11:03 PM.
Referenced Files
F104009796: D47748.diff
Mon, Dec 2, 8:52 AM
Unknown Object (File)
Sun, Dec 1, 3:50 AM
Unknown Object (File)
Fri, Nov 29, 10:49 PM
Unknown Object (File)
Mon, Nov 25, 11:33 PM
Subscribers

Details

Reviewers
bz
Group Reviewers
wireless
Summary

Now that net80211 has this code, just leverage it instead of rolling
our own.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60774
Build 57658: arc lint + arc unit

Event Timeline

vap is used in the debug statement, so (void) it so it is "used" during
non-debug builds.

emaste added inline comments.
sys/dev/ath/if_ath_tx_ht.c
567

Or add __diagused to the variable declaration

bz requested changes to this revision.Thu, Nov 28, 12:52 AM
bz added a subscriber: bz.
bz added inline comments.
sys/dev/ath/if_ath_tx_ht.c
567

@emaste Will that work with the assignment on it?
Alternatively add the needed #ifdef or simply replace vap in the DPRINTF with ni->ni_vap and not have any of these problems.

This revision now requires changes to proceed.Thu, Nov 28, 12:52 AM
sys/dev/ath/if_ath_tx_ht.c
567

We do have some cases like that, e.g.

sys/net/route/route_ctl.c:      struct nhop_object __diagused *nh_src = rnd_src->rnd_nhop;
sys/opencrypto/criov.c: int iol __diagused = uio->uio_iovcnt;
sys/opencrypto/criov.c: int iol __diagused = uio->uio_iovcnt;
sys/opencrypto/criov.c: int iol __diagused = uio->uio_iovcnt;
sys/vm/vm_glue.c:       size_t kpages __diagused = kstack_pages + KSTACK_GUARD_PAGES;
sys/vm/vm_object.c:     vm_object_t object __diagused = objectv;

but indeed just using ni->ni_vap->iv_ampdu_limit would be easiest

This revision is now accepted and ready to land.Mon, Dec 2, 7:20 AM