pf tests: ensure we don't NAT to link-local addresses
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:37 AM.

Tags

None

Referenced Files

	F106634641: D46595.diff
	Fri, Jan 3, 2:34 AM

	F106600017: D46595.diff
	Thu, Jan 2, 12:28 PM

	Unknown Object (File)
	Thu, Dec 5, 10:54 PM

	Unknown Object (File)
	Nov 30 2024, 10:35 AM

	Unknown Object (File)
	Nov 14 2024, 6:31 AM

	Unknown Object (File)
	Nov 8 2024, 3:51 PM

	Unknown Object (File)
	Oct 29 2024, 3:17 AM

	Unknown Object (File)
	Oct 9 2024, 5:12 PM

Subscribers

vegeta_tuxpowered.net

zlei

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rG9746c1e28877: pf tests: ensure we don't NAT to link-local addresses

Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59383
Build 56270: arc lint + arc unit

Event Timeline

kp created this revision.Sep 7 2024, 9:37 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 7 2024, 9:37 AM

kp requested review of this revision.Sep 7 2024, 9:37 AM

Harbormaster completed remote builds in B59383: Diff 143091.Sep 7 2024, 9:37 AM

kp added a parent revision: D46594: pf: exclude link local address from the dynamic interface address pool.Sep 7 2024, 9:37 AM

kp added a child revision: D46596: pf: do not pass af to PFLOG_PACKET.

Looks good to me.

tests/sys/netpfil/pf/nat.sh
253	I'd prefer what we want, but not what we prevent.
256	Nits.

This revision is now accepted and ready to land.Sep 14 2024, 8:16 AM

guest-patmaddox added a subscriber: guest-patmaddox.Sep 19 2024, 5:09 PM

Closed by commit rG9746c1e28877: pf tests: ensure we don't NAT to link-local addresses (authored by kp). · Explain WhySep 19 2024, 8:22 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG9746c1e28877: pf tests: ensure we don't NAT to link-local addresses.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

nat.sh

52 lines

Diff 143091

View Options

tests/sys/netpfil/pf/nat.sh

pf tests: ensure we don't NAT to link-local addressesClosedPublicActions