Page MenuHomeFreeBSD
Differential D41778

bhyve: always generate ACPI tables
ClosedPublic
Actions

Authored by corvink on Sep 8 2023, 6:59 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, May 21, 4:41 AM
Unknown Object (File)
Thu, May 16, 4:46 AM
Unknown Object (File)
Fri, May 10, 3:39 PM
Unknown Object (File)
Wed, May 8, 9:33 AM
Unknown Object (File)
Sun, Apr 28, 8:42 AM
Unknown Object (File)
Sat, Apr 27, 11:27 AM
Unknown Object (File)
Apr 1 2024, 3:01 PM
Unknown Object (File)
Mar 31 2024, 4:52 AM
View All 24 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rG6a0e7f908802: bhyve: always generate ACPI tables
Summary

Most systems don't work properly without sane ACPI tables. Therefore,
we're always generating them.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink created this revision.Sep 8 2023, 6:59 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptSep 8 2023, 6:59 AM
corvink requested review of this revision.Sep 8 2023, 6:59 AM
markj added a comment.Sep 8 2023, 2:06 PM

The bhyve manual page needs to be updated as well.

Would -o acpi_tables=false still work to restore the old behaviour, if one wanted?

corvink updated this revision to Diff 127213.Sep 11 2023, 5:49 AM
  • update man page
corvink added a comment.Sep 11 2023, 5:49 AM
In D41778#952345, @markj wrote:

The bhyve manual page needs to be updated as well.

Would -o acpi_tables=false still work to restore the old behaviour, if one wanted?

Yes, setting -o acpi_tables=false will restore the old behavior.

markj accepted this revision as: markj.Sep 27 2023, 12:43 PM
markj added inline comments.
usr.sbin/bhyve/bhyve.8
115
This revision is now accepted and ready to land.Sep 27 2023, 12:43 PM
Closed by commit rG6a0e7f908802: bhyve: always generate ACPI tables (authored by corvink). · Explain WhySep 28 2023, 8:51 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG6a0e7f908802: bhyve: always generate ACPI tables.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
4 lines
2 lines
8 lines

Diff 127891

View Options

usr.sbin/bhyve/bhyve.8

Loading...
View Options

usr.sbin/bhyve/bhyve_config.5

Loading...
View Options

usr.sbin/bhyve/bhyverun.c

Loading...