Page MenuHomeFreeBSD

make showconfig: set MACHINE appropriately
ClosedPublic

Authored by emaste on Mar 6 2023, 4:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 11:55 PM
Unknown Object (File)
Fri, Apr 26, 11:55 PM
Unknown Object (File)
Fri, Apr 26, 10:35 PM
Unknown Object (File)
Fri, Apr 26, 10:34 PM
Unknown Object (File)
Fri, Apr 26, 8:37 PM
Unknown Object (File)
Thu, Apr 25, 10:04 PM
Unknown Object (File)
Mar 26 2024, 12:03 AM
Unknown Object (File)
Mar 22 2024, 2:43 AM
Subscribers
None

Details

Summary
Previously MACHINE was not set for the showconfig target, and was the
host's value rather than the target.  As a result some machine-dependent
kernel options were not reported with correct defaults in the src.conf
manpage.

PR: 269994
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Mar 6 2023, 4:00 PM
emaste created this revision.
emaste added inline comments.
Makefile.inc1
3393

Perhaps MACHINE_ARCH=${TARGET_ARCH} too? I notice builddtb below sets only MACHINE.

Don't see that MACHINE_ARCH is used, but it's always a good idea to set MACHINE and MACHINE_ARCH in pairs.

This revision is now accepted and ready to land.Mar 6 2023, 8:36 PM
This revision was automatically updated to reflect the committed changes.