Differential D38900

bhyvectl: nvlist leak at send_message()
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on Mar 3 2023, 8:36 PM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Aug 18, 1:37 PM

	Unknown Object (File)
	Fri, Aug 14, 6:33 PM

	Unknown Object (File)
	Tue, Aug 11, 10:11 PM

	Unknown Object (File)
	Mon, Aug 10, 10:58 AM

	Unknown Object (File)
	Sun, Aug 9, 5:17 PM

	Unknown Object (File)
	Sat, Aug 8, 2:52 AM

	Unknown Object (File)
	Fri, Aug 7, 4:50 PM

	Unknown Object (File)
	Tue, Jul 28, 9:05 AM

Subscribers

Details

Reviewers

rew
jhb
markj
corvink

Group Reviewers

Commits

rGf63fd20a9ac2: bhyvectl: don't leak nvlist in send_message
rG942525ab47e9: bhyvectl: don't leak nvlist in send_message

Summary

If error occurs, nvlist_destroy() is not called.

Sponsored by: vStack

Test Plan

Simple patch of series. Just compile and verify that "suspend" command works.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gusev.vitaliy_gmail.com created this revision.Mar 3 2023, 8:36 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 3 2023, 8:36 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

gusev.vitaliy_gmail.com requested review of this revision.Mar 3 2023, 8:36 PM

gusev.vitaliy_gmail.com added a parent revision: D38889: bhyvectl: Correct socket_fd closing in send_message().

gusev.vitaliy_gmail.com added a child revision: D38866: libvmm: Add missed ioctl to vm_ioctl_cmds.

markj accepted this revision as: markj.Mar 3 2023, 8:54 PM

This revision is now accepted and ready to land.Mar 3 2023, 8:54 PM

corvink accepted this revision.Mar 6 2023, 11:33 AM

Closed by commit rG942525ab47e9: bhyvectl: don't leak nvlist in send_message (authored by gusev.vitaliy_gmail.com, committed by corvink). · Explain WhyMar 6 2023, 1:06 PM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG942525ab47e9: bhyvectl: don't leak nvlist in send_message.

corvink added a commit: rGf63fd20a9ac2: bhyvectl: don't leak nvlist in send_message.Mar 17 2023, 10:31 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyvectl/

2 lines

Diff 118380

usr.sbin/bhyvectl/bhyvectl.c

Loading...